linux-kernel - Re: [PATCH net 3/3] net: hibmcge: fix the np_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250801102058.GL8494@horms.kernel.org>
Date: Fri, 1 Aug 2025 11:20:58 +0100
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/3] net: hibmcge: fix the np_link_fai error
 reporting issue

On Thu, Jul 31, 2025 at 09:47:49PM +0800, Jijie Shao wrote:
> Currently, after modifying device port mode, the np_link_ok state
> is immediately checked. At this point, the device may not yet ready,
> leading to the querying of an intermediate state.
> 
> This patch will poll to check if np_link is ok after
> modifying device port mode, and only report np_link_fail upon timeout.
> 
> Fixes: e0306637e85d ("net: hibmcge: Add support for mac link exception handling feature")
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>