linux-kernel - Re: [PATCH v2 4/5] Documentation: PM: QoS: Fix return type and return value description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04333423-56d8-4c4f-a5fe-143b179cdd43@arm.com>
Date: Fri, 1 Aug 2025 12:27:28 +0100
From: Christian Loehle <christian.loehle@....com>
To: Zhongqiu Han <quic_zhonhan@...cinc.com>, rafael@...nel.org,
 lenb@...nel.org, pavel@...nel.org, tony.luck@...el.com,
 reinette.chatre@...el.com, Dave.Martin@....com, james.morse@....com,
 ulf.hansson@...aro.org, amit.kucheria@...aro.org
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] Documentation: PM: QoS: Fix return type and return
 value description

On 7/21/25 13:41, Zhongqiu Han wrote:
> The documentation for cpu_latency_qos_request_active() incorrectly stated
> the return type as 'int' instead of 'bool', and the return value
> description was incomplete. This patch corrects the return type and
> clarifies the return value semantics.
> 
> Fixes: b8e6e27c626e ("Documentation: PM: QoS: Update to reflect previous code changes")
> Signed-off-by: Zhongqiu Han <quic_zhonhan@...cinc.com>
> ---
>  Documentation/power/pm_qos_interface.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/power/pm_qos_interface.rst b/Documentation/power/pm_qos_interface.rst
> index 1ede4cafc2e3..c6b8b9cda166 100644
> --- a/Documentation/power/pm_qos_interface.rst
> +++ b/Documentation/power/pm_qos_interface.rst
> @@ -55,9 +55,9 @@ void cpu_latency_qos_remove_request(handle):
>  int cpu_latency_qos_limit():
>    Returns the aggregated value for the CPU latency QoS.
>  
> -int cpu_latency_qos_request_active(handle):
> -  Returns if the request is still active, i.e. it has not been removed from the
> -  CPU latency QoS list.
> +bool cpu_latency_qos_request_active(handle):
> +  Returns true if the request is still active, i.e. it has not been removed from
> +  the CPU latency QoS list.
>  
>  
>  From user space:

I guess this should be swapped in the series with patch 3? (First fix old, then add
new?)
Anyway it applies in and of itself.

Reviewed-by: Christian Loehle <christian.loehle@....com>