linux-kernel - Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIy0cTjW1ETsY2NS@shell.armlinux.org.uk>
Date: Fri, 1 Aug 2025 13:34:57 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: patchwork-bot+netdevbpf@...nel.org
Cc: Bence Csókás <csokas.bence@...lan.hu>@codeaurora.org,
	geert+renesas@...der.be, sergei.shtylyov@...entembedded.com,
	davem@...emloft.net, robh@...nel.org, andrew@...n.ch,
	andriy.shevchenko@...ux.intel.com, dmitry.torokhov@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	buday.csaba@...lan.hu, hkallweit1@...il.com, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO

On Thu, Jul 31, 2025 at 02:20:08AM +0000, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@...nel.org>:
> 
> On Mon, 28 Jul 2025 17:34:55 +0200 you wrote:
> > Commit bafbdd527d56 ("phylib: Add device reset GPIO support") removed
> > devm_gpiod_get_optional() in favor of the non-devres managed
> > fwnode_get_named_gpiod(). When it was kind-of reverted by commit
> > 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()"), the devm
> > functionality was not reinstated. Nor was the GPIO unclaimed on device
> > remove. This leads to the GPIO being claimed indefinitely, even when the
> > device and/or the driver gets removed.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net] net: mdio_bus: Use devm for getting reset GPIO
>     https://git.kernel.org/netdev/net/c/3b98c9352511

This needs to be reverted, it's an abuse of devm on a device that is
not being probed. Sorry, I don't have time to generate a patch.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!