linux-kernel - Re: [PATCH] dt-bindings: thermal: Convert marvell,armada370-thermal to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjoz6t80.fsf@bootlin.com>
Date: Fri, 01 Aug 2025 15:56:31 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,  Daniel Lezcano
 <daniel.lezcano@...aro.org>,  Zhang Rui <rui.zhang@...el.com>,  Lukasz
 Luba <lukasz.luba@....com>,  Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>,  linux-pm@...r.kernel.org,
  devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: Convert marvell,armada370-thermal
 to DT schema

Hi Rob,

On 02/07/2025 at 17:55:27 -05, "Rob Herring (Arm)" <robh@...nel.org> wrote:

> Convert the Marvell Armada 3xx/XP thermal binding to schema.
>
> Drop the AP80x and CP110 as they have long been deprecated and have
> been replaced by a new binding.

Totally fine with that, but then I would go even further and also drop
the legacy binding implying a size of 4 on the second reg range?

> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---

...

> +examples:
> +  - |
> +    thermal@...18300 {
> +        compatible = "marvell,armada370-thermal";
> +        reg = <0xd0018300 0x4
> +               0xd0018304 0x4>;
> +    };

This example is showing a legacy binding. Even if we decide to keep
supporting it, I think you would prefer to replace the second line:

           reg = <0xd0018300 0x4
  -               0xd0018304 0x4>;
  +               0xd0018304 0x8>;

Thanks,
Miquèl