[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ldo3rv42.fsf@trenco.lwn.net>
Date: Fri, 01 Aug 2025 08:10:05 -0600
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Akira Yokosawa
<akiyks@...il.com>
Subject: Re: [PATCH 05/12] docs: kdoc: split top-level prototype parsing out
of dump_struct()
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> Em Thu, 31 Jul 2025 18:13:19 -0600
> Jonathan Corbet <corbet@....net> escreveu:
>>
>> - struct_members = KernRe(type_pattern + r'([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
>> + struct_members = KernRe(r'(struct|union)([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
>
> I would prefer keeping type_pattern here.
The problem is that type_pattern no longer exists in that function. I'd
have to redefine it, or make it global. It seems like a rather trivial
thing to make global (and, as a result, make people go to the top of the
file to figure out what it really is).
jon
Powered by blists - more mailing lists