linux-kernel - Re: [PATCH v2 3/3] dt-bindings: ufs: qcom: Split SM8650 and similar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8eee4b1c-2965-41e9-9f8f-f771b1af3beb@kernel.org>
Date: Fri, 1 Aug 2025 16:21:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manivannan Sadhasivam <mani@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>,
 Bart Van Assche <bvanassche@....org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-scsi@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: ufs: qcom: Split SM8650 and similar

On 01/08/2025 14:28, Manivannan Sadhasivam wrote:
> On Thu, Jul 31, 2025 at 09:15:54AM GMT, Krzysztof Kozlowski wrote:
>> The binding for Qualcomm SoC UFS controllers grew and it will grow
>> further.  Split SM8650 and SM8750 UFS controllers which:
>> 1. Do not reference ICE as IO address space, but as phandle,
>> 2. Have same order of clocks.
>> 3. Have MCQ IO address space. Document that MCQ address space as
>>    optional to maintain backwards compatibility and because Linux
>>    drivers can operate perfectly fine without it (thus without MCQ
>>    feature).  Linux driver already uses "mcq" as possible name for
>>    "reg-names" property.
> 
> Since Qcom SoC memory maps have holes and shared registers in the whole 'mcq'
> region, it is preferred to map only the required parts. So please drop 'mcq' and
> add 'mcq_sqd', 'mcq_vs' regions.


No, it is not preferred. The docs are clearly stating that there is oone
address space for MCQ and continuous.

We have been fixing above approach you propose also for other devices,
so this should not go to the broken part.


Best regards,
Krzysztof