| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <DM3PPF208195D8DB87B912E14EB611D075BE326A@DM3PPF208195D8D.namprd11.prod.outlook.com>
Date: Fri, 1 Aug 2025 14:23:10 +0000
From: "Kandpal, Suraj" <suraj.kandpal@...el.com>
To: Louis Chauvet <louis.chauvet@...tlin.com>, Dmitry Baryshkov
<dmitry.baryshkov@....qualcomm.com>, Jani Nikula
<jani.nikula@...ux.intel.com>, Harry Wentland <harry.wentland@....com>, "Leo
Li" <sunpeng.li@....com>, Rodrigo Siqueira <siqueira@...lia.com>, "Alex
Deucher" <alexander.deucher@....com>, Christian König
<christian.koenig@....com>, David Airlie <airlied@...il.com>, Simona Vetter
<simona@...ll.ch>, Liviu Dudau <liviu.dudau@....com>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, Rob Clark
<robin.clark@....qualcomm.com>, Dmitry Baryshkov <lumag@...nel.org>, "Abhinav
Kumar" <abhinav.kumar@...ux.dev>, Jessica Zhang
<jessica.zhang@....qualcomm.com>, Sean Paul <sean@...rly.run>, Marijn Suijten
<marijn.suijten@...ainline.org>, Laurent Pinchart
<laurent.pinchart+renesas@...asonboard.com>, Tomi Valkeinen
<tomi.valkeinen+renesas@...asonboard.com>, Kieran Bingham
<kieran.bingham+renesas@...asonboard.com>, Geert Uytterhoeven
<geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, "Dave
Stevenson" <dave.stevenson@...pberrypi.com>, Maíra Canal
<mcanal@...lia.com>, Raspberry Pi Kernel Maintenance
<kernel-list@...pberrypi.com>
CC: "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
"freedreno@...ts.freedesktop.org" <freedreno@...ts.freedesktop.org>,
"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 8/8] drm: writeback: rename
drm_writeback_connector_init_with_encoder()
> Subject: Re: [PATCH 8/8] drm: writeback: rename
> drm_writeback_connector_init_with_encoder()
Same here drm/writeback
Regards,
Suraj Kandpal
>
>
>
> Le 01/08/2025 à 15:51, Dmitry Baryshkov a écrit :
> > Rename drm_writeback_connector_init_with_encoder() to
> > drm_writeback_connector_init() and adapt its interface to follow
> > drmm_writeback_connector_init().
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> > ---
> > drivers/gpu/drm/drm_writeback.c | 14 +++++++-------
> > include/drm/drm_writeback.h | 10 +++++-----
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_writeback.c
> > b/drivers/gpu/drm/drm_writeback.c index
> >
> 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b05953
> 22e
> > 2202a0cf9865 100644
> > --- a/drivers/gpu/drm/drm_writeback.c
> > +++ b/drivers/gpu/drm/drm_writeback.c
> > @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> > }
> >
> > /**
> > - * drm_writeback_connector_init_with_encoder - Initialize a writeback
> > connector with
> > + * drm_writeback_connector_init - Initialize a writeback connector
> > + with
> > * a custom encoder
>
> If I understood correctly your series you want to reduce the usage of non-
> drmm writeback, so maybe we can add a comment to direct poeple to drmm
> variant to avoid new usage of this API?
>
> With or without this:
>
> Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>
>
> > *
> > * @dev: DRM device
> > @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> > *
> > * Returns: 0 on success, or a negative error code
> > */
> > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > - struct drm_encoder *enc,
> > - const struct drm_connector_funcs
> *con_funcs,
> > - const u32 *formats, int n_formats)
> > +int drm_writeback_connector_init(struct drm_device *dev,
> > + struct drm_writeback_connector
> *wb_connector,
> > + const struct drm_connector_funcs
> *con_funcs,
> > + struct drm_encoder *enc,
> > + const u32 *formats, int n_formats)
> > {
> > struct drm_connector *connector = &wb_connector->base;
> > int ret;
> > @@ -284,7 +284,7 @@ int
> > drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> >
> > return ret;
> > }
> > -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
> > +EXPORT_SYMBOL(drm_writeback_connector_init);
> >
> > /**
> > * drm_writeback_connector_cleanup - Cleanup the writeback connector
> > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
> > index
> >
> 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc1
> 1f
> > 9e841316d21b 100644
> > --- a/include/drm/drm_writeback.h
> > +++ b/include/drm/drm_writeback.h
> > @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct
> drm_connector *connector)
> > return container_of(connector, struct drm_writeback_connector, base);
> > }
> >
> > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > - struct drm_encoder *enc,
> > - const struct drm_connector_funcs
> *con_funcs, const u32 *formats,
> > - int n_formats);
> > +int drm_writeback_connector_init(struct drm_device *dev,
> > + struct drm_writeback_connector
> *wb_connector,
> > + const struct drm_connector_funcs
> *con_funcs,
> > + struct drm_encoder *enc,
> > + const u32 *formats, int n_formats);
> >
> > int drmm_writeback_connector_init(struct drm_device *dev,
> > struct drm_writeback_connector
> *wb_connector,
> >
>
> --
> Louis Chauvet, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Powered by blists - more mailing lists