linux-kernel - Re: [PATCH v2] wifi: rtw89: Print just once for unknown C2H classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d503670-6acb-4957-b209-b55f0fa70c32@linux.dev>
Date: Fri, 1 Aug 2025 10:39:46 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Ping-Ke Shih <pkshih@...ltek.com>,
 "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Bitterblue Smith <rtl8821cerfe2@...il.com>
Subject: Re: [PATCH v2] wifi: rtw89: Print just once for unknown C2H classes

On 7/31/25 20:36, Ping-Ke Shih wrote:
> Sean Anderson <sean.anderson@...ux.dev> wrote:
>> On 7/29/25 23:42, Ping-Ke Shih wrote:
>> > Ping-Ke Shih <pkshih@...ltek.com> wrote:
>> >> Sean Anderson <sean.anderson@...ux.dev> wrote:
>> >> > There are more unsupported functions than just LOWRT_RTY. Improve on
>> >> > commit 3b66519b023b ("wifi: rtw89: phy: add dummy c2h handler to avoid
>> >> > warning message") by printing a message just once when we first
>> >> > encounter an unsupported class.
>> >>
>> >> Once I encounter an unsupported class/func, I'll check firmware team if the
>> >> C2H events can be ignored. If so, I add a dummy function to avoid the message.
>> >> If not, I should add code to handle the event.
>> >>
>> >> Do you want to see the message even though it only appears once?
>> >>
>> >> > Do the same for each unsupported func of
>> >> > the supported classes. This prevents messages like
>> >> >
>> >> > rtw89_8922ae 0000:81:00.0: PHY c2h class 2 not support
>> >
>> > Is this a real example?
>> 
>> This is a real example.
>> 
>> > We have handled class 2 (RTW89_PHY_C2H_CLASS_DM), no?
>> 
>> If func != RTW89_PHY_C2H_DM_FUNC_LOWRT_RTY then we fall through to the
>> default case.
> 
> Oh. I see. 
> 
>> 
>> > Please point out the class / func you encountered. Then I can look up vendor
>> > driver or contact internal firmware team to know if we should implement or
>> > just add a dummy function.
>> >
>> > If we defer it, I don't know when we can do it.
>> 
>> rtw89_8922ae 0000:81:00.0: PHY c2h class 2 func 12 not supported
>> 
> 
> The C2H event handler has been added by [1].
> 
> [1] d31c42466b1a ("wifi: rtw89: phy: add C2H event handler for report of FW scan")

OK, but func 12 is still not handled by that commit.

--Sean