linux-kernel - Re: [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dbd00c1-7b47-4e6e-a8bc-5dd0b5d7e539@linux.ibm.com>
Date: Fri, 1 Aug 2025 09:56:50 -0500
From: Eddie James <eajames@...ux.ibm.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...econstruct.com.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Ninad Palsule <ninad@...ux.ibm.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-fsi@...ts.ozlabs.org
Subject: Re: [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays"


On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "no-gpios-delays" property only applies to the "fsi-master-gpio"
> binding and not the "aspeed,ast2[45]00-cf-fsi-master" binding. It
> doesn't really make sense either as the timing is controlled by the
> offloaded firmware.


Thanks for the series Rob. It's fine with me if you take the bindings 
(we're not using the FSI tree now, Grek just merges stuff as needed)

Acked-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>   arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 1 -
>   arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts      | 1 -
>   arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts     | 1 -
>   3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> index 78a5656ef75d..f42254ba6aeb 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> @@ -57,7 +57,6 @@ fsi: gpio-fsi {
>   		compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
>   		#address-cells = <2>;
>   		#size-cells = <0>;
> -		no-gpio-delays;
>   
>   		memory-region = <&coldfire_memory>;
>   		aspeed,sram = <&sram>;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> index b1d0ff85d397..e5b8d07e7622 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> @@ -80,7 +80,6 @@ fsi: gpio-fsi {
>   		compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
>   		#address-cells = <2>;
>   		#size-cells = <0>;
> -		no-gpio-delays;
>   
>   		memory-region = <&coldfire_memory>;
>   		aspeed,sram = <&sram>;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> index 24df24ad9c80..2180fa9b6f24 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> @@ -71,7 +71,6 @@ fsi: gpio-fsi {
>   		compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
>   		#address-cells = <2>;
>   		#size-cells = <0>;
> -		no-gpio-delays;
>   
>   		memory-region = <&coldfire_memory>;
>   		aspeed,sram = <&sram>;
>