linux-kernel - Re: [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ea5177ba-5905-40aa-91b0-9bcb66b6f0d4@linux.ibm.com>
Date: Fri, 1 Aug 2025 10:03:25 -0500
From: Eddie James <eajames@...ux.ibm.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...econstruct.com.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Ninad Palsule <ninad@...ux.ibm.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-fsi@...ts.ozlabs.org
Subject: Re: [PATCH 6/6] dt-bindings: fsi: Convert
 aspeed,ast2400-cf-fsi-master to DT schema


On 7/31/25 17:12, Rob Herring (Arm) wrote:
> Convert the ASpeed Coldfire offloaded GPIO FSI master.
>
> Drop the "fsi-master" compatible as it has not be used consistently and
> doesn't represent anything.


Acked-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>   .../bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml | 81 ++++++++++++++++++++++
>   .../devicetree/bindings/fsi/fsi-master-ast-cf.txt  | 36 ----------
>   2 files changed, 81 insertions(+), 36 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml b/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml
> new file mode 100644
> index 000000000000..690b6c936f18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/aspeed,ast2400-cf-fsi-master.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fsi/aspeed,ast2400-cf-fsi-master.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ASpeed ColdFire offloaded GPIO-based FSI master
> +
> +maintainers:
> +  - Eddie James <eajames@...ux.ibm.com>
> +
> +allOf:
> +  - $ref: /schemas/fsi/fsi-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - aspeed,ast2400-cf-fsi-master
> +      - aspeed,ast2500-cf-fsi-master
> +
> +  clock-gpios:
> +    maxItems: 1
> +    description: GPIO for FSI clock
> +
> +  data-gpios:
> +    maxItems: 1
> +    description: GPIO for FSI data signal
> +
> +  enable-gpios:
> +    maxItems: 1
> +    description: GPIO for enable signal
> +
> +  trans-gpios:
> +    maxItems: 1
> +    description: GPIO for voltage translator enable
> +
> +  mux-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO for pin multiplexing with other functions (eg, external FSI masters)
> +
> +  memory-region:
> +    maxItems: 1
> +    description:
> +      Reference to the reserved memory for the ColdFire. Must be 2M aligned on
> +      AST2400 and 1M aligned on AST2500.
> +
> +  aspeed,cvic:
> +    description: Reference to the CVIC node.
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  aspeed,sram:
> +    description: Reference to the SRAM node.
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - clock-gpios
> +  - data-gpios
> +  - enable-gpios
> +  - trans-gpios
> +  - mux-gpios
> +  - memory-region
> +  - aspeed,cvic
> +  - aspeed,sram
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    fsi-master {
> +      compatible = "aspeed,ast2500-cf-fsi-master";
> +      clock-gpios = <&gpio 0>;
> +      data-gpios = <&gpio 1>;
> +      enable-gpios = <&gpio 2>;
> +      trans-gpios = <&gpio 3>;
> +      mux-gpios = <&gpio 4>;
> +      memory-region = <&coldfire_memory>;
> +      aspeed,cvic = <&cvic>;
> +      aspeed,sram = <&sram>;
> +    };
> diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt b/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt
> deleted file mode 100644
> index 3dc752db748b..000000000000
> --- a/Documentation/devicetree/bindings/fsi/fsi-master-ast-cf.txt
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -Device-tree bindings for ColdFire offloaded gpio-based FSI master driver
> -------------------------------------------------------------------------
> -
> -Required properties:
> - - compatible =
> -	"aspeed,ast2400-cf-fsi-master" for an AST2400 based system
> -   or
> -	"aspeed,ast2500-cf-fsi-master" for an AST2500 based system
> -
> - - clock-gpios = <gpio-descriptor>;	: GPIO for FSI clock
> - - data-gpios = <gpio-descriptor>;	: GPIO for FSI data signal
> - - enable-gpios = <gpio-descriptor>;	: GPIO for enable signal
> - - trans-gpios = <gpio-descriptor>;	: GPIO for voltage translator enable
> - - mux-gpios = <gpio-descriptor>;	: GPIO for pin multiplexing with other
> -                                          functions (eg, external FSI masters)
> - - memory-region = <phandle>;		: Reference to the reserved memory for
> -                                          the ColdFire. Must be 2M aligned on
> -					  AST2400 and 1M aligned on AST2500
> - - aspeed,sram = <phandle>;		: Reference to the SRAM node.
> - - aspeed,cvic = <phandle>;		: Reference to the CVIC node.
> -
> -Examples:
> -
> -    fsi-master {
> -        compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> -
> -	clock-gpios = <&gpio 0>;
> -        data-gpios = <&gpio 1>;
> -        enable-gpios = <&gpio 2>;
> -        trans-gpios = <&gpio 3>;
> -        mux-gpios = <&gpio 4>;
> -
> -	memory-region = <&coldfire_memory>;
> -	aspeed,sram = <&sram>;
> -	aspeed,cvic = <&cvic>;
> -    }
>