linux-kernel - Re: [PATCH] btf: Simplify BTF logic with use of __free(btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250801110705.373c69b4@gandalf.local.home>
Date: Fri, 1 Aug 2025 11:07:05 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>, Masami
 Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko
 <andrii@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, Song Liu
 <song@...nel.org>, KP Singh <kpsingh@...nel.org>
Subject: Re: [PATCH] btf: Simplify BTF logic with use of __free(btf_put)

On Fri, 1 Aug 2025 08:02:24 -0700
Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:

> > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> > index 1d2cf898e21e..480657912c96 100644
> > --- a/kernel/bpf/btf.c
> > +++ b/kernel/bpf/btf.c
> > @@ -3788,7 +3788,7 @@ static int btf_parse_kptr(const struct btf *btf, struct btf_field *field,
> >         /* If a matching btf type is found in kernel or module BTFs, kptr_ref
> >          * is that BTF, otherwise it's program BTF
> >          */
> > -       struct btf *kptr_btf;
> > +       struct btf *kptr_btf __free(btf_put) = NULL;  
> 
> Sorry I hate this __free() style.
> It's not a simplification, but an obfuscation of code and logic.

Well, it's becoming more common. But you are in control of this, so it's
your decision. I wanted this just to get rid of the gotos in my code.

-- Steve