linux-kernel - Re: [PATCH v5 5/5] soc: qcom: ubwc: Add QCS8300 UBWC cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f012c23-914e-4910-a87b-6f9e99c83a25@quicinc.com>
Date: Fri, 1 Aug 2025 10:50:11 +0800
From: Yongxing Mou <quic_yongmou@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Rob Clark
	<robin.clark@....qualcomm.com>,
        Dmitry Baryshkov <lumag@...nel.org>,
        "Abhinav
 Kumar" <abhinav.kumar@...ux.dev>,
        Jessica Zhang
	<jessica.zhang@....qualcomm.com>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Neil
 Armstrong" <neil.armstrong@...aro.org>,
        Kuogee Hsieh
	<quic_khsieh@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>,
        "Konrad
 Dybcio" <konradybcio@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/5] soc: qcom: ubwc: Add QCS8300 UBWC cfg



On 2025/7/30 18:16, Konrad Dybcio wrote:
> On 7/30/25 11:42 AM, Yongxing Mou wrote:
>> The QCS8300 adopts UBWC 4.0, consistent with SA8775P, add 4 channels LP5
>> configuration data according to the specification.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@...cinc.com>
>> ---
>>   drivers/soc/qcom/ubwc_config.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
>> index bd0a98aad9f3b222abcf0a7af85a318caffa9841..389fb871018b65987295db60571c063b4d984d70 100644
>> --- a/drivers/soc/qcom/ubwc_config.c
>> +++ b/drivers/soc/qcom/ubwc_config.c
>> @@ -35,6 +35,16 @@ static const struct qcom_ubwc_cfg_data qcm2290_data = {
>>   	.highest_bank_bit = 15,
>>   };
>>   
>> +static const struct qcom_ubwc_cfg_data qcs8300_data = {
>> +	.ubwc_enc_version = UBWC_4_0,
>> +	.ubwc_dec_version = UBWC_4_0,
>> +	.ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 |
>> +			UBWC_SWIZZLE_ENABLE_LVL3,
>> +	.ubwc_bank_spread = true,
>> +	.highest_bank_bit = 16,
>> +	.macrotile_mode = true,
>> +};
>> +
>>   static const struct qcom_ubwc_cfg_data sa8775p_data = {
>>   	.ubwc_enc_version = UBWC_4_0,
>>   	.ubwc_dec_version = UBWC_4_0,
>> @@ -225,6 +235,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
>>   	{ .compatible = "qcom,msm8998", .data = &msm8998_data },
>>   	{ .compatible = "qcom,qcm2290", .data = &qcm2290_data, },
>>   	{ .compatible = "qcom,qcm6490", .data = &sc7280_data, },
>> +	{ .compatible = "qcom,qcs8300", .data = &qcs8300_data, },
> 
> You can just pass &sc8280xp_data instead, they're equivalent
> 
> Konrad
Acked. Thanks.