linux-kernel - Re: [PATCH cgroup/for-6.16-fixes] cgroup: avoid null de-ref in css_rstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ginu64khh7im4bc7k6xnqf6pqv2pcjreutluwf3mrwrqgyoet6@7u2xbtejr6gi>
Date: Fri, 1 Aug 2025 10:38:24 -0700
From: Shakeel Butt <shakeel.butt@...ux.dev>
To: JP Kobryn <inwardvessel@...il.com>
Cc: tj@...nel.org, mkoutny@...e.com, yosryahmed@...gle.com, 
	hannes@...xchg.org, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, 
	cgroups@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH cgroup/for-6.16-fixes] cgroup: avoid null de-ref in
 css_rstat_exit()

On Thu, Jul 31, 2025 at 12:27:34PM -0700, JP Kobryn wrote:
> This function

Name the function i.e. css_rstat_exit()

> may be called asynchronously in scenarios where preceding
> calls to css_rstat_init() have not completed.

Explain some (or just one) of these scenarios in the commit.

> Return early in this case.
> 
> Signed-off-by: JP Kobryn <inwardvessel@...il.com>
> Suggested-by: Michal Koutný <mkoutny@...e.com>
> Fixes: 5da3bfa029d68 ("cgroup: use separate rstat trees for each subsystem")
> Reported-by: syzbot+8d052e8b99e40bc625ed@...kaller.appspotmail.com

With the updated commit message, please include:

Acked-by: Shakeel Butt <shakeel.butt@...ux.dev>