linux-kernel - Re: [PATCH] kbuild: Re-enable -Wunterminated-string-initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250802011344.GA1736762@ax162>
Date: Fri, 1 Aug 2025 18:13:44 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Masahiro Yamada <masahiroy@...nel.org>,
	Nicolas Schier <nicolas.schier@...ux.dev>,
	linux-kbuild@...r.kernel.org,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] kbuild: Re-enable -Wunterminated-string-initialization

On Fri, Aug 01, 2025 at 05:55:27PM -0700, Kees Cook wrote:
> On Fri, Aug 01, 2025 at 05:43:16PM -0700, Nathan Chancellor wrote:
> > On Fri, Aug 01, 2025 at 05:27:40PM -0700, Kees Cook wrote:
> > > With the few remaining fixes now landed, we can re-enable the option
> > > -Wunterminated-string-initialization for GCC. (Clang does not yet fully
> > > understand the "nonstring" attribute.)
> > > 
> > > Signed-off-by: Kees Cook <kees@...nel.org>
> > 
> > What else does Clang need? Are bugs filed? I had requested support for
> > multidimensional arrays, which Aaron implemented pretty quickly (and the
> > tests seem pretty expansive):
> > 
> > https://github.com/llvm/llvm-project/commit/e8ae77947154e10dbc05cbb95ec9e10d3b0be13e
> 
> Oh! I missed that commit. Did that end up in Clang 21? Let me try some
> test builds with a more recent Clang...

Whoops, linked the wrong change (although that one is still good):

https://github.com/llvm/llvm-project/commit/3d4f979e271d2a1fe0906f4d1b16db108838f98f

But yes, both those changes are in 21.1.0-rc1. I uploaded -rc2 to
kernel.org a couple of days ago: https://kernel.org/pub/tools/llvm/

Cheers,
Nathan