linux-kernel - Re: [PATCH] ALSA: usb-audio: Don't use printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wm7l24dk.wl-tiwai@suse.de>
Date: Sat, 02 Aug 2025 16:19:03 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Don't use printk_ratelimit for debug prints

On Fri, 01 Aug 2025 17:47:10 +0200,
Sean Anderson wrote:
> 
> printk_ratelimit is deprecated, since it shares state with all other
> printk sites. Additionally, the suppression message is printed at
> warning level even though the actual messages are printed at debug and
> are (usually) invisible! This can result in thousands of messages like
> 
> retire_capture_urb: 4992 callbacks suppressed
> 
> in the console, and can inhibit debugging since it is unclear what the
> source of the suppressed callbacks is.
> 
> Switch to dev_dbg_ratelimited which doesn't print anything unless debug
> is enabled.
> 
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>

Applied now.  Thanks.


Takashi