linux-kernel - Re: [PATCH 4/4] usb: xhci: tegra: Support USB wakeup function for Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508021305.3ENY5oQC-lkp@intel.com>
Date: Sat, 2 Aug 2025 13:30:51 +0800
From: kernel test robot <lkp@...el.com>
To: Haotien Hsu <haotienh@...dia.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Mathias Nyman <mathias.nyman@...el.com>,
	Brad Griffis <bgriffis@...dia.com>, Sumit Gupta <sumitg@...dia.com>,
	Vedant Deshpande <vedantd@...dia.com>,
	Akhil R <akhilrajeev@...dia.com>,
	Jinjie Ruan <ruanjinjie@...wei.com>, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Haotien Hsu <haotienh@...dia.com>, Henry Lin <henryl@...dia.com>,
	Jui Chang Kuo <jckuo@...dia.com>, Wayne Chang <waynec@...dia.com>,
	WK Tsai <wtsai@...dia.com>
Subject: Re: [PATCH 4/4] usb: xhci: tegra: Support USB wakeup function for
 Tegra234

Hi Haotien,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on usb/usb-testing usb/usb-next usb/usb-linus tegra/for-next linus/master v6.16 next-20250801]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haotien-Hsu/dt-bindings-usb-Add-wake-up-support-for-Tegra234-XUSB-host-controller/20250801-180040
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250801095748.385437-5-haotienh%40nvidia.com
patch subject: [PATCH 4/4] usb: xhci: tegra: Support USB wakeup function for Tegra234
config: arm-defconfig (https://download.01.org/0day-ci/archive/20250802/202508021305.3ENY5oQC-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 8f09b03aebb71c154f3bbe725c29e3f47d37c26e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508021305.3ENY5oQC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508021305.3ENY5oQC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/host/xhci-tegra.c:1997:15: warning: unused variable 'i' [-Wunused-variable]
    1997 |         unsigned int i;
         |                      ^
   1 warning generated.


vim +/i +1997 drivers/usb/host/xhci-tegra.c

  1992	
  1993	static void tegra_xusb_remove(struct platform_device *pdev)
  1994	{
  1995		struct tegra_xusb *tegra = platform_get_drvdata(pdev);
  1996		struct xhci_hcd *xhci = hcd_to_xhci(tegra->hcd);
> 1997		unsigned int i;
  1998	
  1999		tegra_xusb_deinit_usb_phy(tegra);
  2000	
  2001		pm_runtime_get_sync(&pdev->dev);
  2002		usb_remove_hcd(xhci->shared_hcd);
  2003		usb_put_hcd(xhci->shared_hcd);
  2004		xhci->shared_hcd = NULL;
  2005		usb_remove_hcd(tegra->hcd);
  2006		usb_put_hcd(tegra->hcd);
  2007	
  2008		dma_free_coherent(&pdev->dev, tegra->fw.size, tegra->fw.virt,
  2009				  tegra->fw.phys);
  2010	
  2011		if (tegra->padctl_irq)
  2012			pm_runtime_disable(&pdev->dev);
  2013	
  2014		tegra_xusb_dispose_wake(tegra);
  2015	
  2016		pm_runtime_put(&pdev->dev);
  2017	
  2018		tegra_xusb_disable(tegra);
  2019		tegra_xusb_padctl_put(tegra->padctl);
  2020	}
  2021	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki