linux-kernel - Re: [PATCH][next] media: atomisp: Fix incorrect snprintf format specifiers for signed integers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdfZwmRzGAeN7rLoab2oT8eKyUF1mUGj4d+y98jZS7EHA@mail.gmail.com>
Date: Sat, 2 Aug 2025 10:45:49 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Colin Ian King <colin.i.king@...il.com>, Andy Shevchenko <andy@...nel.org>, 
	Hans de Goede <hansg@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] media: atomisp: Fix incorrect snprintf format
 specifiers for signed integers

On Sat, Aug 2, 2025 at 9:32 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
> On Fri, Aug 01, 2025 at 11:57:43PM +0200, Andy Shevchenko wrote:
> > On Fri, Aug 1, 2025 at 6:01 PM Colin Ian King <colin.i.king@...il.com> wrote:
> > >
> > > There are incorrect %u format specifiers being used to for signed integers,
> > > fix this by using %d instead.
> >
> > Both of them sound to me like the fix of the symptom and not the
> > cause. Can we simply make types of the iterators to be unsigned
> > instead?
>
> Making iterator unsigned by default only increases the rate of bugs.

How? Please, make sure this is relevant to this case.

> (Although, my stats might be biased because I'm only looking at bugs I
> can detect through static analysis).

In general making a variable to be signed that is never negative at
bare minimum is illogical.

P.S.
FWIW, it is a common approach in the media subsystem to require
iterators to be unsigned when they are truly unsigned.

-- 
With Best Regards,
Andy Shevchenko