[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <757cf40c-a48f-4980-b638-35a29a91ecb3@zohomail.com>
Date: Sun, 3 Aug 2025 10:57:55 +0800
From: Xukai Wang <kingxukai@...omail.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
Conor Dooley <conor@...nel.org>, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org, Samuel Holland <samuel.holland@...ive.com>,
Troy Mitchell <TroyMitchell988@...il.com>
Subject: Re: [PATCH v7 3/3] riscv: dts: canaan: Add clock definition for K230
On 2025/7/30 15:06, Krzysztof Kozlowski wrote:
> On Wed, Jul 30, 2025 at 02:43:53AM +0800, Xukai Wang wrote:
>> This patch describes the clock controller integrated in K230 SoC
>> and replace dummy clocks with the real ones for UARTs.
>>
>> For k230-canmv and k230-evb, they provide an additional external
>> pulse input through a pin to serve as clock source.
>>
>> Co-developed-by: Troy Mitchell <TroyMitchell988@...il.com>
>> Signed-off-by: Troy Mitchell <TroyMitchell988@...il.com>
>> Signed-off-by: Xukai Wang <kingxukai@...omail.com>
>> ---
>> arch/riscv/boot/dts/canaan/k230-canmv.dts | 11 +++++++++++
>> arch/riscv/boot/dts/canaan/k230-evb.dts | 11 +++++++++++
>> arch/riscv/boot/dts/canaan/k230.dtsi | 26 ++++++++++++++++++--------
>> 3 files changed, 40 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/riscv/boot/dts/canaan/k230-canmv.dts b/arch/riscv/boot/dts/canaan/k230-canmv.dts
>> index 9565915cead6ad2381ea8249b616e79575feb896..6579d39e2c1690d9e9c2b9c884db528c37473204 100644
>> --- a/arch/riscv/boot/dts/canaan/k230-canmv.dts
>> +++ b/arch/riscv/boot/dts/canaan/k230-canmv.dts
>> @@ -17,8 +17,19 @@ ddr: memory@0 {
>> device_type = "memory";
>> reg = <0x0 0x0 0x0 0x20000000>;
>> };
>> +
>> + timerx_pulse_in: timer_pulse_in {
> Follow DTS coding style.
>
> Please use name for all fixed clocks which matches current format
> recommendation: 'clock-<freq>' (see also the pattern in the binding for
> any other options).
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml?h=v6.11-rc1
Got it, I'll update it to clock-50m as recommended.
Thanks for pointing it out.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists