linux-kernel - Re: [PATCH] acpi: remove unnecessary paranthesis from return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50cafc07-563e-41a7-9286-54db8a7ac731@web.de>
Date: Sun, 3 Aug 2025 16:36:30 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Diksha Kumari <dkdevgan@...look.com>, linux-acpi@...r.kernel.org,
 acpica-devel@...ts.linux.dev
Cc: dikshakdevgan@...il.com, LKML <linux-kernel@...r.kernel.org>,
 Len Brown <lenb@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Robert Moore <robert.moore@...el.com>
Subject: Re: [PATCH] acpi: remove unnecessary paranthesis from return

> checkpatch.pl is generating a warning when return value is
> enclosed in paranthesis. Remove the paranthesis to improve
…

              parenthesis?

You may occasionally put more than 58 characters into text lines
of such a change description.

Please avoid a typo also in the summary phrase.

…
> +++ b/drivers/acpi/acpica/dbconvert.c
> @@ -32,7 +32,7 @@ acpi_status acpi_db_hex_char_to_value(int hex_char, u8 *return_value)
>  	/* Digit must be ascii [0-9a-fA-F] */
>  
>  	if (!isxdigit(hex_char)) {
> -		return (AE_BAD_HEX_CONSTANT);
> +		return AE_BAD_HEX_CONSTANT;
>  	}
…

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n197

Regards,
Markus