linux-kernel - Re: [PATCH V2] acpi: remove unnecessary parenthesis from return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b30ef694-56c2-4023-8d6e-de8f7b8e10e6@gmail.com>
Date: Sun, 3 Aug 2025 22:24:34 +0530
From: Diksha Kumari <dikshakdevgan@...il.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Diksha Kumari <dkdevgan@...look.com>, linux-acpi@...r.kernel.org,
 acpica-devel@...ts.linux.dev
Cc: LKML <linux-kernel@...r.kernel.org>, Len Brown <lenb@...nel.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Robert Moore <robert.moore@...el.com>
Subject: Re: [PATCH V2] acpi: remove unnecessary parenthesis from return
 statement

On 03/08/25 21:38, Markus Elfring wrote:
>> checkpatch.pl is generating a warning when return value is enclosed
>> in parenthesis. Remove the parenthesis to improve code readability.
>                               parentheses?
This is my first patch, so i am not sure what you mean by this.
>
> You propose to omit also some curly brackets, don't you?
ok, i will include this in the next version.
>
> …> ---
>>   drivers/acpi/acpica/dbconvert.c | 43 +++++++++++++++------------------
> …
>
> Did you overlook the addition of patch version descriptions?
> https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n310

yes, went through the document, thanks for the information. I will add 
the change log in next version.

Thanks for reviewing the patch and feedback.

Regards,

Diksha

> Regards,
> Markus