| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250803035816.603405-1-jim.cromie@gmail.com> Date: Sat, 2 Aug 2025 21:57:18 -0600 From: Jim Cromie <jim.cromie@...il.com> To: linux-kernel@...r.kernel.org, jbaron@...mai.com, gregkh@...uxfoundation.org, ukaszb@...omium.org, louis.chauvet@...tlin.com Cc: dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org, daniel.vetter@...ll.ch, tvrtko.ursulin@...ux.intel.com, jani.nikula@...el.com, ville.syrjala@...ux.intel.com, seanpaul@...omium.org, robdclark@...il.com, groeck@...gle.com, yanivt@...gle.com, bleung@...gle.com, quic_saipraka@...cinc.com, will@...nel.org, catalin.marinas@....com, quic_psodagud@...cinc.com, maz@...nel.org, arnd@...db.de, linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, mingo@...hat.com, jim.cromie@...il.com Subject: [PATCH v4 00/58] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y This series fixes dynamic-debug's support for DRM debug-categories. Classmaps-v1 evaded full review, and got committed in 2 chunks: b7b4eebdba7b..6ea3bf466ac6 # core dyndbg changes 0406faf25fb1..ee7d633f2dfb # drm adoption Then DRM-CI found a regression when booting with drm.debug=<initval>; the callsites' static-keys under the drm-dbgs in drm.ko got enabled, but those in drivers & helpers did not, since they weren't yet modprobed, and didn't yet exist. The fix is to retire DECLARE_DYNAMIC_DEBUG_CLASSMAP, and distinguish DYNAMIC_DEBUG_CLASSMAP_USEs from _DEFINEs, then adjust the drivers to _USE the CLASSMAP _DEFINEd by core drm.ko. The _DEFINE exports the classmap, the _USE refs it, adding a linkage dependency, just like __drm_debug already does. rev3 is here: https://lore.kernel.org/lkml/20250402174156.1246171-1-jim.cromie@gmail.com/ changes since are minor: .rework several cleanup patches forward .code/doc/commit-msg tweaks for Louis Chauvet feedback. .refactor dyndbg dynamic-prefix to split TID from cacheable prefix .cflags for drivers/accel borrowing DRM.debug Jim Cromie (58): docs/dyndbg: update examples \012 to \n docs/dyndbg: explain flags parse 1st test-dyndbg: fixup CLASSMAP usage error dyndbg: reword "class unknown," to "class:_UNKNOWN_" dyndbg: make ddebug_class_param union members same size dyndbg: drop NUM_TYPE_ARRAY dyndbg: tweak pr_fmt to avoid expansion conflicts dyndbg: reduce verbose/debug clutter dyndbg: refactor param_set_dyndbg_classes and below dyndbg: tighten fn-sig of ddebug_apply_class_bitmap dyndbg: replace classmap list with a vector dyndbg: macrofy a 2-index for-loop pattern dyndbg,module: make proper substructs in _ddebug_info dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module dyndbg: ddebug_table.mod_name down to _ddebug_info dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code selftests-dyndbg: add a dynamic_debug run_tests target dyndbg: change __dynamic_func_call_cls* macros into expressions dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP dyndbg: detect class_id reservation conflicts dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time dyndbg-test: change do_prints testpoint to accept a loopct dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API dyndbg: treat comma as a token separator dyndbg: split multi-query strings with % selftests-dyndbg: add test_mod_submod dyndbg: drop "protection" of class'd pr_debugs from legacy queries dyndbg: restore classmap protection when theres a controlling_param docs/dyndbg: add classmap info to howto dyndbg: reserve flag-bit _DPRINTK_FLAGS_PREFIX_CACHED dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP for +mfsl flags dyndbg: refactor *dynamic_emit_prefix to split lookups drm: use correct ccflags-y spelling drm-dyndbg: adapt drm core to use dyndbg classmaps-v2 drm-dyndbg: adapt DRM to invoke DYNAMIC_DEBUG_CLASSMAP_PARAM drm-print: fix config-dependent unused variable drm-dyndbg: DRM_CLASSMAP_USE in amdgpu driver drm-dyndbg: DRM_CLASSMAP_USE in i915 driver drm-dyndbg: DRM_CLASSMAP_USE in drm_crtc_helper drm-dyndbg: DRM_CLASSMAP_USE in drm_dp_helper drm-dyndbg: DRM_CLASSMAP_USE in nouveau drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver drm-dyndbg: add DRM_CLASSMAP_USE to virtio_gpu drm-dyndbg: add DRM_CLASSMAP_USE to simpledrm drm-dyndbg: add DRM_CLASSMAP_USE to bochs drm-dyndbg: add DRM_CLASSMAP_USE to etnaviv drm-dyndbg: add DRM_CLASSMAP_USE to gma500 driver drm-dyndbg: add DRM_CLASSMAP_USE to radeon drm-dyndbg: add DRM_CLASSMAP_USE to vmwgfx driver drm-dyndbg: add DRM_CLASSMAP_USE to vkms driver drm-dyndbg: add DRM_CLASSMAP_USE to udl driver drm-dyndbg: add DRM_CLASSMAP_USE to mgag200 driver drm-dyndbg: add DRM_CLASSMAP_USE to the gud driver drm-dyndbg: add DRM_CLASSMAP_USE to the qxl driver drm-dyndbg: add DRM_CLASSMAP_USE to the drm_gem_shmem_helper driver drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN amdxdna: add -DDYNAMIC_DEBUG_MODULE to cflags - RFC accel: add -DDYNAMIC_DEBUG_MODULE to subdir-cflags - RFC .../admin-guide/dynamic-debug-howto.rst | 187 ++++- MAINTAINERS | 3 +- drivers/accel/Makefile | 2 + drivers/accel/amdxdna/Makefile | 2 + drivers/gpu/drm/Kconfig.debug | 1 - drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 +- drivers/gpu/drm/display/drm_dp_helper.c | 12 +- drivers/gpu/drm/drm_crtc_helper.c | 12 +- drivers/gpu/drm/drm_gem_shmem_helper.c | 1 + drivers/gpu/drm/drm_print.c | 38 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 + drivers/gpu/drm/gma500/psb_drv.c | 2 + drivers/gpu/drm/gud/gud_drv.c | 2 + drivers/gpu/drm/i915/i915_params.c | 12 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 + drivers/gpu/drm/nouveau/nouveau_drm.c | 12 +- drivers/gpu/drm/qxl/qxl_drv.c | 2 + drivers/gpu/drm/radeon/radeon_drv.c | 2 + drivers/gpu/drm/sysfb/simpledrm.c | 2 + drivers/gpu/drm/tiny/bochs.c | 2 + drivers/gpu/drm/udl/udl_main.c | 2 + drivers/gpu/drm/virtio/virtgpu_drv.c | 2 + drivers/gpu/drm/vkms/vkms_drv.c | 2 + drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 + drivers/gpu/drm/xe/xe_drm_client.c | 2 + include/asm-generic/vmlinux.lds.h | 5 +- include/drm/drm_print.h | 12 + include/linux/dynamic_debug.h | 254 +++++-- kernel/module/main.c | 15 +- lib/Kconfig.debug | 24 +- lib/Makefile | 5 + lib/dynamic_debug.c | 679 +++++++++++------- lib/test_dynamic_debug.c | 203 ++++-- lib/test_dynamic_debug_submod.c | 21 + tools/testing/selftests/Makefile | 1 + .../testing/selftests/dynamic_debug/Makefile | 9 + tools/testing/selftests/dynamic_debug/config | 7 + .../dynamic_debug/dyndbg_selftest.sh | 373 ++++++++++ 39 files changed, 1423 insertions(+), 508 deletions(-) create mode 100644 lib/test_dynamic_debug_submod.c create mode 100644 tools/testing/selftests/dynamic_debug/Makefile create mode 100644 tools/testing/selftests/dynamic_debug/config create mode 100755 tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh -- 2.50.1
Powered by blists - more mailing lists