linux-kernel - Re: [RFC PATCH v3] ALSA: usb-audio: Add support for TASCAM US-144MKII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025080341-usher-tastiness-0507@gregkh>
Date: Sun, 3 Aug 2025 21:49:48 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Šerif Rami <ramiserifpersia@...il.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Wesley Cheng <quic_wcheng@...cinc.com>
Subject: Re: [RFC PATCH v3] ALSA: usb-audio: Add support for TASCAM US-144MKII

On Sun, Aug 03, 2025 at 10:34:09PM +0200, Šerif Rami wrote:
> +/**
> + * driver_version_show() - Sysfs attribute to display the driver version.
> + * @dev: Pointer to the device structure.
> + * @attr: Pointer to the device attribute structure.
> + * @buf: Buffer to write the version string into.
> + *
> + * This function is a sysfs callback that provides the current driver version
> + * string to user-space when the 'driver_version' attribute is read.
> + *
> + * Return: The number of bytes written to the buffer.
> + */
> +static ssize_t driver_version_show(struct device *dev,
> +				   struct device_attribute *attr, char *buf)
> +{
> +	return sysfs_emit(buf, "%s\n", DRIVER_VERSION);
> +}
> +static DEVICE_ATTR_RO(driver_version);

The driver version makes no sense when it is in the kernel tree, so this
can be removed.

Also, all sysfs files need to be documented in Documentation/ABI/

thanks,

greg k-h