linux-kernel - Re: [PATCH V2 1/2] dt-bindings: arm: qcom: Add bindings for Monaco EVK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba553cec-8004-459f-aec7-f9a800342434@oss.qualcomm.com>
Date: Mon, 4 Aug 2025 23:52:25 +0530
From: Umang Chheda <umang.chheda@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] dt-bindings: arm: qcom: Add bindings for Monaco
 EVK

Hi Krzysztof,

On 8/2/2025 1:16 PM, Krzysztof Kozlowski wrote:
> On 01/08/2025 18:36, Umang Chheda wrote:
>> From: Umang Chheda <uchheda.chheda@....qualcomm.com>
>>
>> Introduce new bindings for the Monaco Evaluation Kit (EVK),
>> an IoT board based on the QCS8300 SoC.
>>
>> Signed-off-by: Umang Chheda <umang.chheda@....qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> This is v2, so where is any changelog?
I have added the changelog in cover letter, But seems I missed
to add it more elaborately and in proper format. Apologize for
the churn will make sure to take care of this in subsequent patches.

> 
> 
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
Ack, will take care of this in subsequent patches.

> Best regards,
> Krzysztof

Thanks,
Umang