linux-kernel - Re: [PATCH v2 0/4] i2c: rtl9300: Fix multi-byte I2C operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f635263b-524f-4b72-8e52-9019d3761544@alliedtelesis.co.nz>
Date: Mon, 4 Aug 2025 20:45:20 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Sven Eckelmann <sven@...fation.org>, Andi Shyti <andi.shyti@...nel.org>
CC: "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Jonas Jelonek
	<jelonek.jonas@...il.com>, Harshal Gohel <hg@...onwunderlich.de>, "Simon
 Wunderlich" <sw@...onwunderlich.de>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: Re: [PATCH v2 0/4] i2c: rtl9300: Fix multi-byte I2C operations


On 04/08/2025 20:35, Sven Eckelmann wrote:
> On Monday, 4 August 2025 00:39:40 CEST Chris Packham wrote:
>> For the series
>>
>> Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> Tested-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> Thank you.
>
>> Note that I've only got the same simple eeprom devices that I did the
>> initial development on so I don't think I've really exercised the block
>> data paths but I can say the changes don't appear to have regressed
>> anything.
> I can understand this problem quite well. We can all only try our best and
> then hope that someone with the actual HW can figure out the specific parts
> which we didn't had access to.
>
>
>> Is you series intended to apply on top of Jonas's? I'm trying to apply
>> yours alone (for various reasons happens to be on top of net-next/main)
>> and I'm getting conflicts.
>
> No, I prepare something for downstream testing (with Jonas' patch):
> https://scanmail.trustwave.com/?c=20988&d=4PCQ6BHJEPBu-7BQIQUZquRTjfxQxIRM1wAL-n5mvg&u=https%3a%2f%2fgithub%2ecom%2fopenwrt%2fopenwrt%2fpull%2f19577%23discussion%5fr2248520949
>
>> Conflict appears to be with
>> https://scanmail.trustwave.com/?c=20988&d=4PCQ6BHJEPBu-7BQIQUZquRTjfxQxIRM11AI-nUytw&u=https%3a%2f%2flore%2ekernel%2eorg%2fall%2f20250615235248%2e529019-1-alexguo1023%40gmail%2ecom%2f
> Thanks, I was not aware of this specific one. I don't exactly know the repo
> structure for I2C Host drivers. But
> git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
> i2c/i2c-host-fixes or i2c/i2c-host-next didn't had this patch. I've also
> checked linux-next and couldn't find the patch at the moment.
>
> I am guessing it is the best when I resent this patch as part of my patchset
> and modify my patches accordingly. The resent will then be done this evening
> (GMT+2). Preview can be found at
> https://scanmail.trustwave.com/?c=20988&d=4PCQ6BHJEPBu-7BQIQUZquRTjfxQxIRM11ZYrXdjvg&u=https%3a%2f%2fgit%2eopen-mesh%2eorg%2flinux-merge%2egit%2flog%2f%3fh%3db4%2fi2c-rtl9300-multi-byte
>
> I've also checked linux-next and couldn't find the patch at the moment.

Oops my bad. I'd applied Alex's patch to test locally then added more 
stuff on top of it and promptly forgot. When I came to test your patches 
I just rebased on top of net-next which I incorrectly assumed had picked 
up Alex's change via linux-next hence reporting the conflict which you 
can't see. Glad you managed to figure it out on your end for v3.

>
> Kind regards,
> 	Sven