linux-kernel - Re: [PATCH] iio: light: ltr390: Add remove callback with needed support in device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfJzVAJYC9-2oyfV4qBLmraXRgqZFcho6b7orW+1sYkXw@mail.gmail.com>
Date: Mon, 4 Aug 2025 23:05:30 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Akshay Jindal <akshayaj.lkd@...il.com>
Cc: anshulusr@...il.com, jic23@...nel.org, dlechner@...libre.com, 
	nuno.sa@...log.com, andy@...nel.org, shuah@...nel.org, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: light: ltr390: Add remove callback with needed
 support in device registration

On Mon, Aug 4, 2025 at 9:25 PM Akshay Jindal <akshayaj.lkd@...il.com> wrote:
>
> Implement the .remove() callback in the ltr390 driver to ensure proper
> cleanup when the device is removed.
>
> Set client data with i2c_set_clientdata() to ensure indio_dev is accessible
> in .remove(). Replace devm_iio_device_register() with iio_device_register()
> and explicitly unregister the device to align with the updated removal path
> and follow common patterns used in other IIO drivers.

Doesn't sound right to me. HAve you investigated PM runtime paths?
Looking at what the code you added there it sounds to me like a part
of PM runtime ->suspend() callback.

-- 
With Best Regards,
Andy Shevchenko