linux-kernel - Re: [PATCH] drm/drm_bridge: Document 'connector' parameter in drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCkknr+w3B0NWM065Rr_d9n9QEak7YmhehByQTdfwYr30RbSQ@mail.gmail.com>
Date: Mon, 4 Aug 2025 23:24:58 +0200
From: sukrut heroorkar <hsukrut3@...il.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Robert Foss <rfoss@...nel.org>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>, open list <linux-kernel@...r.kernel.org>, 
	skhan@...uxfoundation.org, david.hunter.linux@...il.com
Subject: Re: [PATCH] drm/drm_bridge: Document 'connector' parameter in drm_bridge_detect()

Hi Laurent,

On Sun, Aug 3, 2025 at 6:56 PM Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
>
> On Sat, Aug 02, 2025 at 06:13:05PM +0200, Sukrut Heroorkar wrote:
> > drm: drm_bridge: fix missing parameter documentation
> >
> > The function documentation was missing description for the
> > parameter 'connector'.
> >
> > Add missing function parameter documentation for drm_bridge_detect()
> > to fix kernel-doc warnings.
> >
> > Warning: drivers/gpu/drm/drm_bridge.c:1241 function parameter 'connector' not described in 'drm_bridge_detect'
> >
>
> A Fixes: tag would be nice.
>
> > Signed-off-by: Sukrut Heroorkar <hsukrut3@...il.com>
> > ---
> >  drivers/gpu/drm/drm_bridge.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> > index dd45d9b504d8..387a3b6cda54 100644
> > --- a/drivers/gpu/drm/drm_bridge.c
> > +++ b/drivers/gpu/drm/drm_bridge.c
> > @@ -1227,6 +1227,7 @@ EXPORT_SYMBOL(drm_atomic_bridge_chain_check);
> >  /**
> >   * drm_bridge_detect - check if anything is attached to the bridge output
> >   * @bridge: bridge control structure
> > + * @connector: connector associated with the bridge
>
> "associated with the bridge" isn't very clear.
>
> >   *
> >   * If the bridge supports output detection, as reported by the
> >   * DRM_BRIDGE_OP_DETECT bridge ops flag, call &drm_bridge_funcs.detect for the
>
> --
> Regards,
>
> Laurent Pinchart


Thanks for the review.
I will send a V2 shortly with updated connector description and Fixes
tag, as suggested.