| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b49ba0c5-4942-42eb-bc63-bc9d4fc49d83@suswa.mountain>
Date: Mon, 4 Aug 2025 09:45:42 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, Pratap Nirujogi <pratap.nirujogi@....com>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Alex Deucher <alexander.deucher@....com>, Bin Du <bin.du@....com>,
Mario Limonciello <mario.limonciello@....com>
Subject: drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c:126 isp_genpd_add_device()
warn: can 'pdev' even be NULL?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a6923c06a3b2e2c534ae28c53a7531e76cc95cfa
commit: fd14786071021bb63b0ab32b95257a594e46f8d4 drm/amd/amdgpu: Add ISP Generic PM Domain (genpd) support
config: x86_64-randconfig-161-20250802 (https://download.01.org/0day-ci/archive/20250802/202508021712.RXyDnVIn-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202508021712.RXyDnVIn-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c:126 isp_genpd_add_device() warn: can 'pdev' even be NULL?
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c:159 isp_genpd_remove_device() warn: can 'pdev' even be NULL?
vim +/pdev +126 drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
fd14786071021b Pratap Nirujogi 2025-05-29 118 static int isp_genpd_add_device(struct device *dev, void *data)
fd14786071021b Pratap Nirujogi 2025-05-29 119 {
fd14786071021b Pratap Nirujogi 2025-05-29 120 struct generic_pm_domain *gpd = data;
fd14786071021b Pratap Nirujogi 2025-05-29 121 struct platform_device *pdev = container_of(dev, struct platform_device, dev);
fd14786071021b Pratap Nirujogi 2025-05-29 122 struct amdgpu_isp *isp = container_of(gpd, struct amdgpu_isp, ispgpd);
fd14786071021b Pratap Nirujogi 2025-05-29 123 struct amdgpu_device *adev = isp->adev;
fd14786071021b Pratap Nirujogi 2025-05-29 124 int ret;
fd14786071021b Pratap Nirujogi 2025-05-29 125
fd14786071021b Pratap Nirujogi 2025-05-29 @126 if (!pdev)
pdev can't be NULL. It's dev minus a non-zero offset. Just delete
this check.
fd14786071021b Pratap Nirujogi 2025-05-29 127 return -EINVAL;
fd14786071021b Pratap Nirujogi 2025-05-29 128
fd14786071021b Pratap Nirujogi 2025-05-29 129 if (!dev->type->name) {
fd14786071021b Pratap Nirujogi 2025-05-29 130 drm_dbg(&adev->ddev, "Invalid device type to add\n");
fd14786071021b Pratap Nirujogi 2025-05-29 131 goto exit;
fd14786071021b Pratap Nirujogi 2025-05-29 132 }
fd14786071021b Pratap Nirujogi 2025-05-29 133
fd14786071021b Pratap Nirujogi 2025-05-29 134 if (strcmp(dev->type->name, "mfd_device")) {
fd14786071021b Pratap Nirujogi 2025-05-29 135 drm_dbg(&adev->ddev, "Invalid isp mfd device %s to add\n", pdev->mfd_cell->name);
fd14786071021b Pratap Nirujogi 2025-05-29 136 goto exit;
fd14786071021b Pratap Nirujogi 2025-05-29 137 }
fd14786071021b Pratap Nirujogi 2025-05-29 138
fd14786071021b Pratap Nirujogi 2025-05-29 139 ret = pm_genpd_add_device(gpd, dev);
fd14786071021b Pratap Nirujogi 2025-05-29 140 if (ret) {
fd14786071021b Pratap Nirujogi 2025-05-29 141 drm_err(&adev->ddev, "Failed to add dev %s to genpd %d\n",
fd14786071021b Pratap Nirujogi 2025-05-29 142 pdev->mfd_cell->name, ret);
fd14786071021b Pratap Nirujogi 2025-05-29 143 return -ENODEV;
fd14786071021b Pratap Nirujogi 2025-05-29 144 }
fd14786071021b Pratap Nirujogi 2025-05-29 145
fd14786071021b Pratap Nirujogi 2025-05-29 146 exit:
fd14786071021b Pratap Nirujogi 2025-05-29 147 /* Continue to add */
fd14786071021b Pratap Nirujogi 2025-05-29 148 return 0;
fd14786071021b Pratap Nirujogi 2025-05-29 149 }
fd14786071021b Pratap Nirujogi 2025-05-29 150
fd14786071021b Pratap Nirujogi 2025-05-29 151 static int isp_genpd_remove_device(struct device *dev, void *data)
fd14786071021b Pratap Nirujogi 2025-05-29 152 {
fd14786071021b Pratap Nirujogi 2025-05-29 153 struct generic_pm_domain *gpd = data;
fd14786071021b Pratap Nirujogi 2025-05-29 154 struct platform_device *pdev = container_of(dev, struct platform_device, dev);
fd14786071021b Pratap Nirujogi 2025-05-29 155 struct amdgpu_isp *isp = container_of(gpd, struct amdgpu_isp, ispgpd);
fd14786071021b Pratap Nirujogi 2025-05-29 156 struct amdgpu_device *adev = isp->adev;
fd14786071021b Pratap Nirujogi 2025-05-29 157 int ret;
fd14786071021b Pratap Nirujogi 2025-05-29 158
fd14786071021b Pratap Nirujogi 2025-05-29 @159 if (!pdev)
fd14786071021b Pratap Nirujogi 2025-05-29 160 return -EINVAL;
fd14786071021b Pratap Nirujogi 2025-05-29 161
fd14786071021b Pratap Nirujogi 2025-05-29 162 if (!dev->type->name) {
fd14786071021b Pratap Nirujogi 2025-05-29 163 drm_dbg(&adev->ddev, "Invalid device type to remove\n");
fd14786071021b Pratap Nirujogi 2025-05-29 164 goto exit;
fd14786071021b Pratap Nirujogi 2025-05-29 165 }
fd14786071021b Pratap Nirujogi 2025-05-29 166
fd14786071021b Pratap Nirujogi 2025-05-29 167 if (strcmp(dev->type->name, "mfd_device")) {
fd14786071021b Pratap Nirujogi 2025-05-29 168 drm_dbg(&adev->ddev, "Invalid isp mfd device %s to remove\n",
fd14786071021b Pratap Nirujogi 2025-05-29 169 pdev->mfd_cell->name);
fd14786071021b Pratap Nirujogi 2025-05-29 170 goto exit;
fd14786071021b Pratap Nirujogi 2025-05-29 171 }
fd14786071021b Pratap Nirujogi 2025-05-29 172
fd14786071021b Pratap Nirujogi 2025-05-29 173 ret = pm_genpd_remove_device(dev);
fd14786071021b Pratap Nirujogi 2025-05-29 174 if (ret) {
fd14786071021b Pratap Nirujogi 2025-05-29 175 drm_err(&adev->ddev, "Failed to remove dev from genpd %d\n", ret);
fd14786071021b Pratap Nirujogi 2025-05-29 176 return -ENODEV;
fd14786071021b Pratap Nirujogi 2025-05-29 177 }
fd14786071021b Pratap Nirujogi 2025-05-29 178
fd14786071021b Pratap Nirujogi 2025-05-29 179 exit:
fd14786071021b Pratap Nirujogi 2025-05-29 180 /* Continue to remove */
fd14786071021b Pratap Nirujogi 2025-05-29 181 return 0;
fd14786071021b Pratap Nirujogi 2025-05-29 182 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists