linux-kernel - Re: [PATCH 1/2] ALSA: hda/realtek: Accelerate the front MIC charging and discharging of the 897 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h5yn1s44.wl-tiwai@suse.de>
Date: Mon, 04 Aug 2025 09:08:27 +0200
From: Takashi Iwai <tiwai@...e.de>
To: wangdich9700@....com
Cc: lgirdwood@...il.com,
	broonie@...nel.org,
	perex@...ex.cz,
	tiwai@...e.com,
	linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org,
	wangdicheng <wangdicheng@...inos.cn>
Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Accelerate the front MIC charging and discharging of the 897 codec

On Mon, 04 Aug 2025 08:17:58 +0200,
Takashi Iwai wrote:
> 
> On Mon, 04 Aug 2025 05:05:17 +0200,
> wangdich9700@....com wrote:
> > 
> > From: wangdicheng <wangdicheng@...inos.cn>
> > 
> > The front MIC capacitance of the Inspur board is too large, resulting in a longer charging and discharging time required,
> > which in turn prevents recording for 5 seconds before startup.
> > Therefore, software is used to increase the delay by 2 seconds to avoid this issue.
> 
> First off, the HD-audio code was replaced in the latest Linus tree to
> sound/hda/* directories, so please adapt the patches accordingly.
> 
> About the code change:
> 
> - The 2.5 seconds wait is way too long and inappropriate to be put in
>   the resume callback.  It has to be fixed differently.
> 
> - Does it apply really to all devices with 0x10ec1304?  It's Realtek's
>   vendor id, so this can match to many devices.
> 
> - Last but not least, it's not nice to have a code that depends on the
>   certain vendor id there.  Again, please implement in a different way
>   so that it can be handled in more device-specific code rather than
>   the common function.

One more thing: the mailing list for Linux kernel sound stuff is
linux-sound@...r.kernel.org.  Please use this one instead of
alsa-devel ML.


thanks,

Takashi