linux-kernel - RE: [PATCH] mmc: sdhci-of-arasan: Ensure CD logic stabilization before power-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BY5PR12MB4258DFBCF57951B76758417ADB23A@BY5PR12MB4258.namprd12.prod.outlook.com>
Date: Mon, 4 Aug 2025 07:11:03 +0000
From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>
To: Prasanna Kumar T S M <ptsm@...ux.microsoft.com>, Adrian Hunter
	<adrian.hunter@...el.com>, "Simek, Michal" <michal.simek@....com>, Ulf
 Hansson <ulf.hansson@...aro.org>
CC: "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>,
	"saikrishna12468@...il.com" <saikrishna12468@...il.com>
Subject: RE: [PATCH] mmc: sdhci-of-arasan: Ensure CD logic stabilization
 before power-up

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Prasanna Kumar,

> -----Original Message-----
> From: Prasanna Kumar T S M <ptsm@...ux.microsoft.com>
> Sent: Friday, August 1, 2025 6:34 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@....com>; Adrian Hunter
> <adrian.hunter@...el.com>; Simek, Michal <michal.simek@....com>; Ulf
> Hansson <ulf.hansson@...aro.org>
> Cc: linux-mmc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; git (AMD-Xilinx) <git@....com>;
> saikrishna12468@...il.com
> Subject: Re: [PATCH] mmc: sdhci-of-arasan: Ensure CD logic stabilization before
> power-up
>
> Hi Sai Krishna,
>
> On 25-07-2025 11:19, Potthuri, Sai Krishna wrote:
> >> Will this work with all Arasan variants?
> > Yes, this is expected to work across all Arasan variants that comply with the
> standard
> > SDHCI register definitions. The SDHCI_CD_STABLE bit is defined in both the
> > standard SDHCI specification and Arasan's user guide.
>
> As SDHCI_CD_STABLE bit is defined in SDHCI specification, why are you
> making a driver specific fix? Is this problem specific to Arasan eMMC?
> If not, does it make sense to make this a framework level change instead
> of a driver specific change?
>
> Given that you are planning to add a quirk, doing this in common code
> would be better.
Agree, with the quirk approach we can move the logic to framework(sdhci.c) and
make it as a common code.
I will move the logic to sdhci_set_power_noreg() function.

Regards
Sai Krishna

>
> > On Xilinx/AMD Versal and ZynqMP platforms, the CD stable bit is typically set
> within
> > a few milliseconds. However, to be on the safer side and ensure compatibility
> across
> > all Arasan variants, a timeout of 1 second is added.
> > Please let me know if you prefer to increase the timeout or if this logic should be
> > enabled by a platform specific quirk.
>
> Thanks,
>
> Prasanna Kumar