linux-kernel - Re: [PATCH net] phy: mscc: Fix timestamping for vsc8584

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250804073940.4wgpstdm53atrbbq@DEN-DL-M31836.microchip.com>
Date: Mon, 4 Aug 2025 09:39:40 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Vladimir Oltean <olteanv@...il.com>
CC: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <richardcochran@...il.com>, <viro@...iv.linux.org.uk>,
	<quentin.schulz@...tlin.com>, <atenart@...nel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] phy: mscc: Fix timestamping for vsc8584

The 08/01/2025 14:26, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi Horatiu,

Hi Vladimir,

> 
> On Thu, Jul 31, 2025 at 02:19:20PM +0200, Horatiu Vultur wrote:
> > diff --git a/drivers/net/phy/mscc/mscc.h b/drivers/net/phy/mscc/mscc.h
> > index 6a3d8a754eb8d..7281eea2395bd 100644
> > --- a/drivers/net/phy/mscc/mscc.h
> > +++ b/drivers/net/phy/mscc/mscc.h
> > @@ -362,6 +362,13 @@ struct vsc85xx_hw_stat {
> >       u16 mask;
> >  };
> >
> > +struct vsc8531_skb {
> > +     struct list_head list;
> > +
> > +     struct sk_buff *skb;
> > +     u32 ns;
> > +};
> 
> Can you map a typed structure over the skb->cb area to avoid allocating
> this encapsulating structure over the sk_buff?

I think it is a great idea. I can map struct vsc8531_skb directly on
skb->cb and then drop the allocation.

-- 
/Horatiu