linux-kernel - Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c0433be-1008-4d6e-9672-b1908383e162@collabora.com>
Date: Mon, 4 Aug 2025 09:59:37 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Julien Massot <julien.massot@...labora.com>, kernel@...labora.com,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Ikjoon Jang <ikjn@...omium.org>,
 Enric Balletbo i Serra <eballetbo@...nel.org>,
 Chen-Yu Tsai <wenst@...omium.org>, Weiyi Lu <weiyi.lu@...iatek.com>,
 Eugen Hristev <eugen.hristev@...aro.org>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Julien Massot <jmassot@...labora.com>, Sean Wang <sean.wang@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-sound@...r.kernel.org,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys
 binding variant

Il 01/08/25 13:18, Julien Massot ha scritto:
> Update the mediatek,audsys binding to support the mt8183-audiosys
> compatible, which uses a different audio controller binding
> (mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller.
> 
> Signed-off-by: Julien Massot <julien.massot@...labora.com>
> ---
>   .../bindings/arm/mediatek/mediatek,audsys.yaml          | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> index 45d4a6620041b11cf6e943de49a42f3fcd91e1b9..5d9d91f9c5802240ac7d411c5632ae6663d15f29 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> @@ -23,6 +23,7 @@ properties:
>                 - mediatek,mt7622-audsys
>                 - mediatek,mt8167-audsys
>                 - mediatek,mt8173-audsys
> +              - mediatek,mt8183-audiosys
>                 - mediatek,mt8183-audsys
>                 - mediatek,mt8186-audsys
>                 - mediatek,mt8192-audsys
> @@ -41,7 +42,6 @@ properties:
>       const: 1
>   
>     audio-controller:
> -    $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
>       type: object
>   
>   required:
> @@ -50,6 +50,21 @@ required:
>   
>   additionalProperties: false
>   
> +allOf:

I think you can do it without the allOf here as well.

if:
   properties:
     compatible:
       contains...
then:
   properties
     ...
else:
  ... etc

after which

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mediatek,mt8183-audiosys
> +    then:
> +      properties:
> +        audio-controller:
> +          $ref: /schemas/sound/mt8183-afe-pcm.yaml#
> +    else:
> +      properties:
> +        audio-controller:
> +          $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
> +
>   examples:
>     - |
>       #include <dt-bindings/interrupt-controller/arm-gic.h>
>