linux-kernel - [PATCH] imx: Replace redundant return value judgment with PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250804084921.231257-1-liaoyuanhong@vivo.com>
Date: Mon,  4 Aug 2025 16:49:21 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>
Cc: Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Liao Yuanhong <liaoyuanhong@...o.com>,
	imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] imx: Replace redundant return value judgment with PTR_ERR_OR_ZERO()

Replace redundant return value judgment with PTR_ERR_OR_ZERO() to
enhance code readability.

Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
---
 drivers/firmware/imx/imx-scu-soc.c | 5 +----
 drivers/firmware/imx/sm-cpu.c      | 5 +----
 drivers/firmware/imx/sm-lmm.c      | 5 +----
 3 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c
index 497192320562..ecea39ea708f 100644
--- a/drivers/firmware/imx/imx-scu-soc.c
+++ b/drivers/firmware/imx/imx-scu-soc.c
@@ -145,8 +145,5 @@ int imx_scu_soc_init(struct device *dev)
 		return -ENOMEM;
 
 	soc_dev = soc_device_register(soc_dev_attr);
-	if (IS_ERR(soc_dev))
-		return PTR_ERR(soc_dev);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(soc_dev);
 }
diff --git a/drivers/firmware/imx/sm-cpu.c b/drivers/firmware/imx/sm-cpu.c
index 091b014f739f..431ea1963bd9 100644
--- a/drivers/firmware/imx/sm-cpu.c
+++ b/drivers/firmware/imx/sm-cpu.c
@@ -61,10 +61,7 @@ static int scmi_imx_cpu_probe(struct scmi_device *sdev)
 	}
 
 	imx_cpu_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_IMX_CPU, &ph);
-	if (IS_ERR(imx_cpu_ops))
-		return PTR_ERR(imx_cpu_ops);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(imx_cpu_ops);
 }
 
 static const struct scmi_device_id scmi_id_table[] = {
diff --git a/drivers/firmware/imx/sm-lmm.c b/drivers/firmware/imx/sm-lmm.c
index 6807bf563c03..1abd406d7d16 100644
--- a/drivers/firmware/imx/sm-lmm.c
+++ b/drivers/firmware/imx/sm-lmm.c
@@ -67,10 +67,7 @@ static int scmi_imx_lmm_probe(struct scmi_device *sdev)
 	}
 
 	imx_lmm_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_IMX_LMM, &ph);
-	if (IS_ERR(imx_lmm_ops))
-		return PTR_ERR(imx_lmm_ops);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(imx_lmm_ops);
 }
 
 static const struct scmi_device_id scmi_id_table[] = {
-- 
2.34.1