linux-kernel - Re: [PATCH] powerpc/64: Drop unnecessary 'rc' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dtzjm4ngxlmpevlvjadtvnl5kfwxrkngrouxssq6skxvywe2kt@gbi362blsi3k>
Date: Mon, 4 Aug 2025 15:00:09 +0530
From: Gautam Menghani <gautam@...ux.ibm.com>
To: Xichao Zhao <zhao.xichao@...o.com>
Cc: maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com,
        christophe.leroy@...roup.eu, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/64: Drop unnecessary 'rc' variable

On Fri, Aug 01, 2025 at 11:59:08AM +0800, Xichao Zhao wrote:
> Simplify the code to enhance readability and maintain a consistent 
> coding style.
> 
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> ---
>  arch/powerpc/kernel/setup_64.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 7284c8021eeb..8fd7cbf3bd04 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -141,10 +141,7 @@ void __init check_smt_enabled(void)
>  			smt_enabled_at_boot = 0;
>  		else {
>  			int smt;
> -			int rc;
> -
> -			rc = kstrtoint(smt_enabled_cmdline, 10, &smt);
> -			if (!rc)
> +			if (!kstrtoint(smt_enabled_cmdline, 10, &smt))
>  				smt_enabled_at_boot =
>  					min(threads_per_core, smt);
>  		}


Thanks for the cleanup

Acked-by: Gautam Menghani <gautam@...ux.ibm.com>

Thanks,
Gautam