linux-kernel - Re: [PATCH 2/2] powerpc/powernv/pci: Fix underflow and leak issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d0b203f-b753-41ee-97c5-fa4739f4915c@kaod.org>
Date: Mon, 4 Aug 2025 12:18:57 +0200
From: Cédric Le Goater <clg@...d.org>
To: Nam Cao <namcao@...utronix.de>, Madhavan Srinivasan
 <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>,
 Nicholas Piggin <npiggin@...il.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Gautam Menghani <gautam@...ux.ibm.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH 2/2] powerpc/powernv/pci: Fix underflow and leak issue

On 8/4/25 12:07, Nam Cao wrote:
> pnv_irq_domain_alloc() allocates interrupts at parent's interrupt
> domain. If it fails in the progress, all allocated interrupts are
> freed.
> 
> The number of successfully allocated interrupts so far is stored
> "i". However, "i - 1" interrupts are freed. This is broken:
> 
>      - One interrupt is not be freed
> 
>      - If "i" is zero, "i - 1" wraps around
> 
> Correct the number of freed interrupts to "i".
> 
> Fixes: 0fcfe2247e75 ("powerpc/powernv/pci: Add MSI domains")
> Signed-off-by: Nam Cao <namcao@...utronix.de>
> Cc: stable@...r.kernel.org
> ---
>   arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cédric Le Goater <clg@...hat.com>

Thanks,

C.