linux-kernel - Re: [PATCH net] phy: mscc: Fix timestamping for vsc8584

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250804103052.nhpboyqcybwhomzl@skbuf>
Date: Mon, 4 Aug 2025 13:30:52 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, richardcochran@...il.com,
	viro@...iv.linux.org.uk, quentin.schulz@...tlin.com,
	atenart@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] phy: mscc: Fix timestamping for vsc8584

On Mon, Aug 04, 2025 at 01:24:32PM +0300, Vladimir Oltean wrote:
> On Mon, Aug 04, 2025 at 09:39:40AM +0200, Horatiu Vultur wrote:
> > I think it is a great idea. I can map struct vsc8531_skb directly on
> > skb->cb and then drop the allocation.
> 
> Ok.
> 
> Another set of suggestions on the patch, all regarding list processing:

One more: skb queues (struct sk_buff_head) have their own API
(skb_queue_tail() etc), and more importantly, they have a spinlock
already. You should probably use that.