linux-kernel - Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bf7c9-d394-7519-795b-c8d455ee9d0@inria.fr>
Date: Mon, 4 Aug 2025 14:10:15 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Jakub Kicinski <kuba@...nel.org>
cc: MD Danish Anwar <danishanwar@...com>, 
    "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
    Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, 
    Andrew Lunn <andrew+netdev@...n.ch>, 
    Mengyuan Lou <mengyuanlou@...-swift.com>, 
    Michael Ellerman <mpe@...erman.id.au>, 
    Madhavan Srinivasan <maddy@...ux.ibm.com>, Fan Gong <gongfan1@...wei.com>, 
    Lee Trager <lee@...ger.us>, Lorenzo Bianconi <lorenzo@...nel.org>, 
    Geert Uytterhoeven <geert+renesas@...der.be>, 
    Lukas Bulwahn <lukas.bulwahn@...hat.com>, 
    Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>, 
    netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
    linux-kernel@...r.kernel.org, cocci@...ia.fr, 
    Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation
 for RPMSG-ETH Driver



On Wed, 23 Jul 2025, Jakub Kicinski wrote:

> On Wed, 23 Jul 2025 13:33:18 +0530 MD Danish Anwar wrote:
> > +   - Vendors must ensure the magic number matches the value expected by the
> > +     Linux driver (see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> > +     source).
>
> For some reason this trips up make coccicheck:
>
> EXN: Failure("unexpected paren order") in /home/cocci/testing/Documentation/networking/device_drivers/ethernet/rpmsg_eth.rst
>
> If I replace the brackets with a comma it works:
>
>    - Vendors must ensure the magic number matches the value expected by the
>      Linux driver, see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
>      source.
>
> Could you make that change in the next revision to avoid the problem?
>
> Julia, is there an easy way to make coccinelle ignore files which
> don't end with .c or .h when using --use-patch-diff ?

Perhaps not.  I can adjust it.

julia