linux-kernel - Re: [PATCH 05/12] docs: kdoc: split top-level prototype parsing out of dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250804142009.0f1bb402@foz.lan>
Date: Mon, 4 Aug 2025 14:20:09 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Jonathan Corbet <corbet@....net>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Akira Yokosawa
 <akiyks@...il.com>
Subject: Re: [PATCH 05/12] docs: kdoc: split top-level prototype parsing out
 of dump_struct()

Em Fri, 01 Aug 2025 08:10:05 -0600
Jonathan Corbet <corbet@....net> escreveu:

> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> 
> > Em Thu, 31 Jul 2025 18:13:19 -0600
> > Jonathan Corbet <corbet@....net> escreveu:  
> >>  
> >> -        struct_members = KernRe(type_pattern + r'([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
> >> +        struct_members = KernRe(r'(struct|union)([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')  
> >
> > I would prefer keeping type_pattern here.   
> 
> The problem is that type_pattern no longer exists in that function.

Ah, I see. If this is the only place now where we have this, then it
sounds OK to have it like that.

Feel free to add my R-B:

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

> I'd
> have to redefine it, or make it global.  It seems like a rather trivial
> thing to make global (and, as a result, make people go to the top of the
> file to figure out what it really is).


Thanks,
Mauro