linux-kernel - [PATCH 0/4] mfd: qnap-mcu: Some fixes / improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250804130726.3180806-1-heiko@sntech.de>
Date: Mon,  4 Aug 2025 15:07:22 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: lee@...nel.org
Cc: heiko@...ech.de,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/4] mfd: qnap-mcu: Some fixes / improvements

While digging through the mcu functions, I came across some deficits I
introduced with the initial driver submission, so trying to make that
a bit nicer with this series.

I struggled a bit with the ordering of qnap_mcu_write error-check
and conversion to guard(mutex). Converting to guard before the
error check would need dropping the ret variable, just to re-add it
one patch later - to not cause unused variable warning.

Additionally the error handling could be considered a fix, so makes
sense to have in front.

Heiko Stuebner (4):
  mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header
  mfd: qnap-mcu: handle errors returned from qnap_mcu_write
  mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec
  mfd: qnap-mcu: improve structure in qnap_mcu_exec

 drivers/mfd/qnap-mcu.c       | 30 +++++++++++++++---------------
 include/linux/mfd/qnap-mcu.h |  2 ++
 2 files changed, 17 insertions(+), 15 deletions(-)

-- 
2.47.2