linux-kernel - Re: [PATCH net-next v10 10/15] net: phy: marvell10g: Support SFP through phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250804155339.1131365f@fedora.home>
Date: Mon, 4 Aug 2025 15:53:39 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Jakub Kicinski <kuba@...nel.org>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell
 King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org,
 Christophe Leroy <christophe.leroy@...roup.eu>, Herve Codina
 <herve.codina@...tlin.com>, Florian Fainelli <f.fainelli@...il.com>, Heiner
 Kallweit <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Köry Maincent <kory.maincent@...tlin.com>, Marek
 Behún <kabel@...nel.org>, Oleksij Rempel
 <o.rempel@...gutronix.de>, Nicolò Veronese
 <nicveronese@...il.com>, Simon Horman <horms@...nel.org>,
 mwojtas@...omium.org, Antoine Tenart <atenart@...nel.org>,
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Romain
 Gantois <romain.gantois@...tlin.com>, Daniel Golle <daniel@...rotopia.org>,
 Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next v10 10/15] net: phy: marvell10g: Support SFP
 through phy_port

On Sat, 26 Jul 2025 23:17:11 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> > +	} else if (port->not_described) {
> > +		/* This PHY can do combo-ports, i.e. 2 MDI outputs, usually one
> > +		 * of them going to an SFP and the other one to a RJ45
> > +		 * connector. If we don't have any representation for the port
> > +		 * in DT, and we are dealing with a non-SFP port, then we
> > +		 * mask the port's capabilities to report BaseT-only modes
> > +		 */
> > +		port->mediums = BIT(ETHTOOL_LINK_MEDIUM_BASET);
> > +
> > +		phy_port_filter_supported(port);  
> 
> That seems a little bit error prone. Maybe add a helper to set
> port->mediums, which also makes the phy_port_filter_supported() call?

Good point, as this will always have to be done in similar situations
for other drivers.

I'll add that, thanks !

Maxime