linux-kernel - Re: [PATCH v10 4/6] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97a3e5f8-92d7-43f0-ab99-77e248589adc@intel.com>
Date: Mon, 4 Aug 2025 07:19:52 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: "Reshetova, Elena" <elena.reshetova@...el.com>
Cc: "jarkko@...nel.org" <jarkko@...nel.org>,
 "seanjc@...gle.com" <seanjc@...gle.com>, "Huang, Kai" <kai.huang@...el.com>,
 "mingo@...nel.org" <mingo@...nel.org>,
 "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>, "Mallick, Asit K"
 <asit.k.mallick@...el.com>,
 "Scarlata, Vincent R" <vincent.r.scarlata@...el.com>,
 "Cai, Chong" <chongc@...gle.com>, "Aktas, Erdem" <erdemaktas@...gle.com>,
 "Annapurve, Vishal" <vannapurve@...gle.com>,
 "Bondarevska, Nataliia" <bondarn@...gle.com>,
 "Raynor, Scott" <scott.raynor@...el.com>
Subject: Re: [PATCH v10 4/6] x86/sgx: Define error codes for use by
 ENCLS[EUPDATESVN]

On 8/4/25 00:21, Reshetova, Elena wrote:
...
>>> +	EUPDATESVN	= 0x18,
>>>  };
>>
>> This update is not consistent with the changelog nor the patch subject.
> 
> I can remove the alignment fix.  

It's not the alignment.

It's the definition of EUPDATESVN that goes completely unmentioned.

...
>> Ideally, we find a way to relay this in a very succinct way.
> 
> Could you please elaborate what you mean by this? 
> Changing the description? The name or? 

Relaying it in the comment next to the definition would be best.