[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9f4e1263-c3d4-45be-a964-3eb0de828d95@redhat.com>
Date: Mon, 4 Aug 2025 16:36:10 +0200
From: David Hildenbrand <david@...hat.com>
To: Wei Yang <richard.weiyang@...il.com>,
Aboorva Devarajan <aboorvad@...ux.ibm.com>
Cc: akpm@...ux-foundation.org, Liam.Howlett@...cle.com,
lorenzo.stoakes@...cle.com, shuah@...nel.org, pfalcato@...e.de,
ziy@...dia.com, baolin.wang@...ux.alibaba.com, npache@...hat.com,
ryan.roberts@....com, dev.jain@....com, baohua@...nel.org,
linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org, donettom@...ux.ibm.com, ritesh.list@...il.com
Subject: Re: [PATCH v3 3/7] selftest/mm: Fix ksm_funtional_test failures
>> }
>>
>> @@ -338,6 +341,7 @@ static void test_unmerge_zero_pages(void)
>> ksft_test_result(!range_maps_duplicates(map, size),
>> "KSM zero pages were unmerged\n");
>> unmap:
>> + ksm_unmerge();
>> munmap(map, size);
>> }
>>
>> @@ -366,6 +370,7 @@ static void test_unmerge_discarded(void)
>> ksft_test_result(!range_maps_duplicates(map, size),
>> "Pages were unmerged\n");
>> unmap:
>> + ksm_unmerge();
>> munmap(map, size);
>> }
>>
>> @@ -452,6 +457,7 @@ static void test_unmerge_uffd_wp(void)
>> close_uffd:
>> close(uffd);
>> unmap:
>> + ksm_unmerge();
>> munmap(map, size);
>> }
>> #endif
>> @@ -515,6 +521,7 @@ static int test_child_ksm(void)
>> else if (map == MAP_MERGE_SKIP)
>> return -3;
>>
>> + ksm_unmerge();
>> munmap(map, size);
>> return 0;
>> }
>> @@ -548,6 +555,7 @@ static void test_prctl_fork(void)
>>
>> child_pid = fork();
>> if (!child_pid) {
>> + init_global_file_handles();
>
> Would this leave fd in parent as orphan?
Probably yes, but only until the child quits, so likely we don't care.
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists