linux-kernel - Re: [PATCH] net: tcp_ipv4.c: Add missing space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+UZOcFKjoTLJtx0M4-TPy1Do6CVsJ7C-OWkoLGQq_F8w@mail.gmail.com>
Date: Mon, 4 Aug 2025 07:51:48 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Osama Albahrani <osalbahr@...il.com>
Cc: Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>, 
	"David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tcp_ipv4.c: Add missing space

On Mon, Aug 4, 2025 at 7:39 AM Osama Albahrani <osalbahr@...il.com> wrote:
>
> This commit resolves the following checkpatch.pl error:
>
> ```
> ERROR: spaces required around that '=' (ctx:VxW)
> +       .twsk_destructor= tcp_twsk_destructor,
>                         ^
> ```
>
> Assuming the purpose was to align the equal signs, I also added a space in
> the previous line.
>
> Signed-off-by: Osama Albahrani <osalbahr@...il.com>
> ---

I have a patch removing .twsk_destructor completely, waiting for
net-next to open next week.

(DCCP has been removed a while ago)

So I would vote for not bothering with your patch.