linux-kernel - Re: [PATCH] drm/bridge: panel: convert to use ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6408ca9a-bf7b-45b4-982c-8a91d2ebf7d3@linaro.org>
Date: Mon, 4 Aug 2025 17:17:14 +0200
From: neil.armstrong@...aro.org
To: zhang.enpei@....com.cn, andrzej.hajda@...el.com
Cc: rfoss@...nel.org, laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: panel: convert to use ERR_CAST()

On 19/07/2025 10:47, zhang.enpei@....com.cn wrote:
> From: Zhang Enpei <zhang.enpei@....com.cn>
> 
> Use ERR_CAST() since the macro clearly indicates that this is a pointer
> to an error value and a type conversion was performed.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@....com.cn>
> ---
>   drivers/gpu/drm/bridge/panel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 184a8b7049a7..7d2d67e56cee 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -291,7 +291,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
>          panel_bridge = devm_drm_bridge_alloc(panel->dev, struct panel_bridge, bridge,
>                                               &panel_bridge_bridge_funcs);
>          if (IS_ERR(panel_bridge))
> -               return (void *)panel_bridge;
> +               return ERR_CAST(panel_bridge);
> 
>          panel_bridge->connector_type = connector_type;
>          panel_bridge->panel = panel;

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>