linux-kernel - Re: [PATCH] drm: panel: orisetech: improve error handling during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca6aa2e8-d15e-4d7a-a440-5ab814699390@linaro.org>
Date: Mon, 4 Aug 2025 17:19:28 +0200
From: neil.armstrong@...aro.org
To: Akhilesh Patil <akhilesh@...iitb.ac.in>, quic_jesszhan@...cinc.com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, simona@...ll.ch, asrivats@...hat.com
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 akhileshpatilvnit@...il.com, skhan@...uxfoundation.org
Subject: Re: [PATCH] drm: panel: orisetech: improve error handling during
 probe

On 24/07/2025 18:08, Akhilesh Patil wrote:
> Use dev_err_probe() helper as directed by core driver model to handle
> driver probe error. Use standard helper defined at drivers/base/core.c
> to maintain code consistency.
> 
> Inspired by,
> commit a787e5400a1ce ("driver core: add device probe log helper")
> 
> Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>
> ---
>   drivers/gpu/drm/panel/panel-orisetech-ota5601a.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c b/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c
> index fc87f61d4400..e971d1536654 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c
> @@ -277,11 +277,8 @@ static int ota5601a_probe(struct spi_device *spi)
>   		       DRM_MODE_CONNECTOR_DPI);
>   
>   	err = drm_panel_of_backlight(&panel->drm_panel);
> -	if (err) {
> -		if (err != -EPROBE_DEFER)
> -			dev_err(dev, "Failed to get backlight handle\n");
> -		return err;
> -	}
> +	if (err)
> +		return dev_err_probe(dev, err, "Failed to get backlight handle\n");
>   
>   	drm_panel_add(&panel->drm_panel);
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>