linux-kernel - Re: [PATCH] dpll: zl3073x: ZL3073X_I2C and ZL3073X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5c159e6-75d0-433d-92b4-f5be3fc0c1c2@redhat.com>
Date: Mon, 4 Aug 2025 17:32:54 +0200
From: Ivan Vecera <ivecera@...hat.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Prathosh Satish <Prathosh.Satish@...rochip.com>,
 Jakub Kicinski <kuba@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] dpll: zl3073x: ZL3073X_I2C and ZL3073X_SPI should depend
 on NET

On 02. 08. 25 5:53 odp., Geert Uytterhoeven wrote:
> When making ZL3073X invisible, it was overlooked that ZL3073X depends on
> NET, while ZL3073X_I2C and ZL3073X_SPI do not, causing:
> 
>      WARNING: unmet direct dependencies detected for ZL3073X when selected by ZL3073X_I2C
>      WARNING: unmet direct dependencies detected for ZL3073X when selected by ZL3073X_SPI
>      WARNING: unmet direct dependencies detected for ZL3073X
> 	Depends on [n]: NET [=n]
> 	Selected by [y]:
> 	- ZL3073X_I2C [=y] && I2C [=y]
> 	Selected by [y]:
> 	- ZL3073X_SPI [=y] && SPI [=y]
> 
> Fix this by adding the missing dependencies to ZL3073X_I2C and
> ZL3073X_SPI.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508022110.nTqZ5Ylu-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202508022351.NHIxPF8j-lkp@intel.com/
> Fixes: a4f0866e3dbbf3fe ("dpll: Make ZL3073X invisible")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   drivers/dpll/zl3073x/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dpll/zl3073x/Kconfig b/drivers/dpll/zl3073x/Kconfig
> index 9915f7423dea370c..5bbca14005813134 100644
> --- a/drivers/dpll/zl3073x/Kconfig
> +++ b/drivers/dpll/zl3073x/Kconfig
> @@ -16,7 +16,7 @@ config ZL3073X
>   
>   config ZL3073X_I2C
>   	tristate "I2C bus implementation for Microchip Azurite devices"
> -	depends on I2C
> +	depends on I2C && NET
>   	select REGMAP_I2C
>   	select ZL3073X
>   	help
> @@ -28,7 +28,7 @@ config ZL3073X_I2C
>   
>   config ZL3073X_SPI
>   	tristate "SPI bus implementation for Microchip Azurite devices"
> -	depends on SPI
> +	depends on NET && SPI
>   	select REGMAP_SPI
>   	select ZL3073X
>   	help

Acked-by: Ivan Vecera <ivecera@...hat.com>