linux-kernel - Re: [PATCH] drm/bridge: document HDMI CEC callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db6ae287-88f8-4f05-97ad-458930f9f429@linaro.org>
Date: Mon, 4 Aug 2025 17:38:50 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Andrzej Hajda <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] drm/bridge: document HDMI CEC callbacks

On 01/08/2025 12:46, Dmitry Baryshkov wrote:
> Provide documentation for the drm_bridge callbacks related to the
> DRM_BRIDGE_OP_HDMI_CEC_ADAPTER flag.
> 
> Fixes: a74288c8ded7 ("drm/display: bridge-connector: handle CEC adapters")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/r/20250611140933.1429a1b8@canb.auug.org.au
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>   include/drm/drm_bridge.h | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)
> 
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 8ed80cad77ec4b40d0aa6159e802a2839d5b8792..b0e6653ee42ecc088f420a9a32cf3b0428737a4a 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -866,13 +866,61 @@ struct drm_bridge_funcs {
>   				      struct drm_connector *connector,
>   				      bool enable, int direction);
>   
> +	/**
> +	 * @hdmi_cec_init:
> +	 *
> +	 * Initialize CEC part of the bridge.
> +	 *
> +	 * This callback is optional, it can be implemented by bridges that
> +	 * set the @DRM_BRIDGE_OP_HDMI_CEC_ADAPTER flag in their
> +	 * &drm_bridge->ops.
> +	 *
> +	 * Returns:
> +	 * 0 on success, a negative error code otherwise
> +	 */
>   	int (*hdmi_cec_init)(struct drm_bridge *bridge,
>   			     struct drm_connector *connector);
>   
> +	/**
> +	 * @hdmi_cec_enable:
> +	 *
> +	 * Enable or disable the CEC adapter inside the bridge.
> +	 *
> +	 * This callback is optional, it can be implemented by bridges that
> +	 * set the @DRM_BRIDGE_OP_HDMI_CEC_ADAPTER flag in their
> +	 * &drm_bridge->ops.
> +	 *
> +	 * Returns:
> +	 * 0 on success, a negative error code otherwise
> +	 */
>   	int (*hdmi_cec_enable)(struct drm_bridge *bridge, bool enable);
>   
> +	/**
> +	 * @hdmi_cec_log_addr:
> +	 *
> +	 * Set the logical address of the CEC adapter inside the bridge.
> +	 *
> +	 * This callback is optional, it can be implemented by bridges that
> +	 * set the @DRM_BRIDGE_OP_HDMI_CEC_ADAPTER flag in their
> +	 * &drm_bridge->ops.
> +	 *
> +	 * Returns:
> +	 * 0 on success, a negative error code otherwise
> +	 */
>   	int (*hdmi_cec_log_addr)(struct drm_bridge *bridge, u8 logical_addr);
>   
> +	/**
> +	 * @hdmi_cec_transmit:
> +	 *
> +	 * Transmit the message using the CEC adapter inside the bridge.
> +	 *
> +	 * This callback is optional, it can be implemented by bridges that
> +	 * set the @DRM_BRIDGE_OP_HDMI_CEC_ADAPTER flag in their
> +	 * &drm_bridge->ops.
> +	 *
> +	 * Returns:
> +	 * 0 on success, a negative error code otherwise
> +	 */
>   	int (*hdmi_cec_transmit)(struct drm_bridge *bridge, u8 attempts,
>   				 u32 signal_free_time, struct cec_msg *msg);
>   
> 
> ---
> base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
> change-id: 20250801-drm-hdmi-cec-docs-541ee6afa5fa
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>