linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: adm1275: add sq24905c support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48996ed0-8d5f-4bb0-ab66-8be71c0a59e4@roeck-us.net>
Date: Mon, 4 Aug 2025 08:59:09 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: ChiShih Tsai <tomtsai764@...il.com>, linux-hwmon@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org
Cc: jdelvare@...e.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, corbet@....net, t630619@...il.com
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: adm1275: add sq24905c support

On 8/4/25 05:48, ChiShih Tsai wrote:
> Add support for sq24905c Hot-Swap Controller and Digital Power Monitor.
> 
> Signed-off-by: ChiShih Tsai <tomtsai764@...il.com>
> ---
>   .../bindings/hwmon/adi,adm1275.yaml           | 20 +++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> index ddb72857c846..6aa300086c84 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> @@ -30,6 +30,7 @@ properties:
>         - adi,adm1281
>         - adi,adm1293
>         - adi,adm1294
> +      - silergy,sq24905c
>   
>     reg:
>       maxItems: 1
> @@ -46,6 +47,18 @@ properties:
>       $ref: /schemas/types.yaml#/definitions/uint32
>       enum: [1, 2, 4, 8, 16, 32, 64, 128]
>   
> +  silergy,volt-curr-sample-average:
> +    description: |
> +      Number of samples to be used to report voltage and current values.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
> +
> +  silergy,power-sample-average:
> +    description: |
> +      Number of samples to be used to report power values.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
> +
>   allOf:
>     - $ref: hwmon-common.yaml#
>     - if:
> @@ -96,12 +109,17 @@ allOf:
>                 - adi,adm1281
>                 - adi,adm1293
>                 - adi,adm1294
> +              - silergy,sq24905c
>       then:
>         properties:
>           adi,volt-curr-sample-average:
>             default: 128
>           adi,power-sample-average:
>             default: 1
> +        silergy,volt-curr-sample-average:
> +          default: 128
> +        silergy,power-sample-average:
> +          default: 1
>   

I personally don't think this warrants new properties. However, if warranted,
this needs to be qualified to only apply for the Silergy parts.

Guenter

>   required:
>     - compatible
> @@ -121,5 +139,7 @@ examples:
>               shunt-resistor-micro-ohms = <500>;
>               adi,volt-curr-sample-average = <128>;
>               adi,power-sample-average = <128>;
> +            silergy,volt-curr-sample-average = <128>;
> +            silergy,power-sample-average = <1>;
>           };
>       };