lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025080440-foam-oversight-53b5@gregkh>
Date: Mon, 4 Aug 2025 17:50:52 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Abinash Singh <abinashsinghlalotra@...il.com>
Cc: amit@...nel.org, arnd@...db.de, virtualization@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/char/virtio_console : refactor resource cleanup
 to use scope-based helpers

On Mon, Aug 04, 2025 at 05:00:20PM +0530, Abinash Singh wrote:
> This refactors the 'alloc_buf' function to replace traditional goto-based
> error handling with scope-based cleanup helpers.
> 
> No functional changes intended.

Please only do this in new code being submitted, no need to change any
existing code unless it is needed.

> Signed-off-by: Abinash Singh <abinashsinghlalotra@...il.com>
> ---
>  drivers/char/virtio_console.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)

Did you test this?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ