linux-kernel - Re: [PATCH v3 8/9] clk: divider, gate: create regmap-backed copies of gate and divider clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250805-slit-scrunch-e19f8afec16d@spud>
Date: Tue, 5 Aug 2025 18:13:47 +0100
From: Conor Dooley <conor@...nel.org>
To: Gabriel FERNANDEZ <gabriel.fernandez@...s.st.com>
Cc: sboyd@...nel.org, Conor Dooley <conor.dooley@...rochip.com>,
	Daire McNamara <daire.mcnamara@...rochip.com>,
	pierre-henry.moussay@...rochip.com,
	valentina.fernandezalanis@...rochip.com,
	Michael Turquette <mturquette@...libre.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Jassi Brar <jassisinghbrar@...il.com>, Lee Jones <lee@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 8/9] clk: divider, gate: create regmap-backed copies
 of gate and divider clocks

On Thu, Jul 31, 2025 at 01:23:49PM +0200, Gabriel FERNANDEZ wrote:
> 
> On 6/23/25 14:56, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@...rochip.com>
> > 
> > Implement regmap-backed copies of gate and divider clocks by replacing
> > the iomem pointer to the clock registers with a regmap and offset
> > within.
> > 
> > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Hi Conor,
> 
> Excellent patch, thank you! I really needed this and will be using it.
> 
> I would also be interested in having a similar regmap-backed implementation
> for the multiplexer clock.  Do you have any plans to work on this as well?
> If not, I’d be happy to propose a patch for it, with your agreement.

The only types of clock my driver needed were gate and divider, so those
were all I focused on. I don't really have a plan to implement more,
particular given the lack of feedback here means that I don't even know
if what I have done is what Stephen wants. The rest of your comments
seem reasonable, and I'll try to implement them in a new version.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)