linux-kernel - Re: [PATCH] media: starfive: camss: Use common dma-contig dma addr helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250805004522.GA24627@pendragon.ideasonboard.com>
Date: Tue, 5 Aug 2025 03:45:22 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Paul Kocialkowski <paulk@...-base.io>
Cc: linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Jack Zhu <jack.zhu@...rfivetech.com>,
	Changhuang Liang <changhuang.liang@...rfivetech.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH] media: starfive: camss: Use common dma-contig dma addr
 helper

Hi Paul,

Thank you for the patch.

On Fri, Aug 01, 2025 at 10:21:49AM +0200, Paul Kocialkowski wrote:
> The vb2_plane_cookie helpers is not meant to be used directly by
> drivers using the generic dma-contig allocator.
> 
> Use the common helper to retrieve the plane dma address instead.
> 
> Signed-off-by: Paul Kocialkowski <paulk@...-base.io>
> ---
>  drivers/staging/media/starfive/camss/stf-video.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/starfive/camss/stf-video.c b/drivers/staging/media/starfive/camss/stf-video.c
> index a0420eb6a0aa..b0b9b70b9641 100644
> --- a/drivers/staging/media/starfive/camss/stf-video.c
> +++ b/drivers/staging/media/starfive/camss/stf-video.c
> @@ -167,10 +167,8 @@ static int video_buf_init(struct vb2_buffer *vb)
>  	struct stfcamss_video *video = vb2_get_drv_priv(vb->vb2_queue);
>  	struct stfcamss_buffer *buffer = to_stfcamss_buffer(vbuf);
>  	const struct v4l2_pix_format *fmt = &video->active_fmt.fmt.pix;
> -	dma_addr_t *paddr;
>  
> -	paddr = vb2_plane_cookie(vb, 0);
> -	buffer->addr[0] = *paddr;
> +	buffer->addr[0] = vb2_dma_contig_plane_dma_addr(vb, 0);

That looks good,

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

However, I think the driver should be dropped from the kernel. It has
been merged in staging because it wasn't complete, and startfive made it
clear they don't plan to work on it anymore.

Would you like to submit a patch to drop the driver instead ?

>  
>  	if (fmt->pixelformat == V4L2_PIX_FMT_NV12)
>  		buffer->addr[1] =

-- 
Regards,

Laurent Pinchart